VBA code for index/match function not working properly - excel

Question

I wrote the following macro to create a dynamic index/match formula which retrieves data from one sheet (US acq_CUSIP data) and outputs it to another (ws_output). My code is below, ws_input contains a bunch of data incl. a list of companies (in the range R43:R3223) and calendar years (for example, 2011, 2012, etc.). When trying to run the macro, I get the following error: "Application-defined or object-defined error", which seems to be due to the errors in the resulting index formula. How can I fix this? Thank you!
Sub fetching_acq_data_compustat()
Dim ws_input As Worksheet
Dim strTkr As String
Dim rngTkr As Range
Dim c As Range
Dim ws_output As Worksheet
Dim strTaxPaid As String
Dim StrPretaxIncome As String
Dim strSpecItem As String
Dim strTkrCell As String
Dim Dated As String
Dim strDatedCell As String
Set ws_input = ThisWorkbook.Sheets("MA_ExportFiltered_RawData")
Set ws_output = ThisWorkbook.Sheets("Acquirer_ETR")
ws_output.Activate
With ws_output
Set rngTkr = .Range("R43:R3223")
i = 1
For Each c In rngTkr
strTkrCell = c.Address
k = 14
If k < 16 Then
Dated = c.Offset(0, k).Address
strDatedCell = Dated
ws_output.Range("A1").Offset(2, 0).Value = c.Offset(0, 14).Value
ActiveCell.Offset(0, i).Value = "=INDEX( 'US acq_CUSIP data'!$A$3:$AJ$77388" & ";" & "MATCH(1; ('US acq_CUSIP data'!$I$3:$I$77388=" & "MA_ExportFiltered_RawData!" & strTkrCell & ")*('US acq_CUSIP data'!$C$3:$C$77388=" & "MA_ExportFiltered_RawData!" & strDatedCell & ");0); 26)"
ActiveCell.Offset(-1, 0).Value = 26
ActiveCell.Offset(-1, 0).Value = c.Value
k = k + 1
End If
Next
End With
End Sub

Answer 1

This isn't an answer to the question, but it's too long to post in comments (plus the comment discussion was getting too long anyway).
If as you say the above is your entire code without anything trimmed out for relevance, then I've refactored it to the below (which does exactly the same actions just with less code):
Sub fetching_acq_data_compustat()
'Variables:
'Worksheets:
Dim ws_input As Worksheet, ws_output As Worksheet
Set ws_input = ThisWorkbook.Sheets("MA_ExportFiltered_RawData")
Set ws_output = ThisWorkbook.Sheets("Acquirer_ETR")
'Ranges:
Dim rngTkr As Range, c As Range
'Strings:
Dim strTkrCell As String, strDatedCell As String
With ws_output
.Activate
Set rngTkr = .Range("R43:R3223")
For Each c In rngTkr ' This loop achieves nothing because the same cells are getting edited every time, the end result will be just the results of the last iteration of the loop
strTkrCell = c.Address
strDatedCell = c.Offset(0, 14).Address
' there were variables i and k in here which weren't doing anything;
' i got set but then never incremented
' k got set and incremented, but then reset to its original value for every loop of c
.Range("A1").Offset(2, 0).Value = c.Offset(0, 14).Value
' substituted 'Range("A1")' for 'Activecell'; that may be wrong.
.Range("A1").Offset(0, 1).Value = _
"=INDEX('US acq_CUSIP data'!$A$3:$AJ$77388;MATCH(1;('US acq_CUSIP data'!$I$3:$I$77388=MA_ExportFiltered_RawData!" & strTkrCell & ")*('US acq_CUSIP data'!$C$3:$C$77388=MA_ExportFiltered_RawData!" & strDatedCell & ");0); 26)"
.Range("A1").Offset(-1, 0).Value = c.Value
Next
End With
End Sub
As mentioned in the comments (and further noticeable from the code) there were variables that weren't getting used, and the loop through c isn't achieving anything either.
I recommend you use F8 to step through your code line-by-line and work out if it's doing what you expected it would.