NSIS Exec not executing and gives return code of 0 - nsis

I'm running the script shown below and neither the directory nor the logical link are being created. I'm not sure what I'm doing wrong. Each call returns a code of 0 (zero). I'm using the information available here
Execute Command-Line Command from NSIS
https://nsis.sourceforge.io/Docs/Chapter4.html
RequestExecutionLevel admin
# includes
!include .\PrependEnv.nsh
# definitions
Outfile "007-exec-examples.exe"
InstallDir "C:\temp\nsis-examples\007-exe-examples"
Page Directory
Page InstFiles
# section to copy files and manipulate env variable
Section
# copy files
DetailPrint ""
DetailPrint "Copying files to $InstDir..."
DetailPrint ""
SetOutPath "$InstDir\resources"
File /a /r "resources\"
# create a dir
DetailPrint ""
DetailPrint "Making dir $InstDir"
Exec 'mkdir $InstDir\delete_me'
Pop $0
DetailPrint "RegPrependString:Error=$0 (Should be 0)"
# create a logical link
DetailPrint ""
DetailPrint "Creating logical link as C:\_YES to $InstDir\delete_me."
Exec 'mklink /D $InstDir\_MY_LINK $InstDir\delete_me'
Pop $0
DetailPrint "RegPrependString:Error=$0 (Should be 0)"
SectionEnd
--- EDIT ----------------------------
This also fails but does give a indication that an error occurred.
# ---
#
# This script tries to create a dir and a logical link.
#
# ---
RequestExecutionLevel admin
# includes
!include .\PrependEnv.nsh
# definitions
Outfile "008-exec-examples.exe"
InstallDir "C:\temp\nsis-examples\008-exe-examples"
ShowInstDetails show
Page Directory
Page InstFiles
# section to copy files and manipulate env variable
Section
# copy files
DetailPrint ""
DetailPrint "Copying files to $InstDir..."
DetailPrint ""
SetOutPath "$InstDir\resources"
File /a /r "resources\"
# create a dir
DetailPrint ""
DetailPrint "Making dir $InstDir\delete_me"
nsExec::ExecToStack 'mkdir $InstDir\delete_me'
Pop $0
Pop $1
DetailPrint "RegPrependString:Error=$0 (Should be 0)"
DetailPrint "$1"
# create a logical link
DetailPrint ""
DetailPrint "Creating logical link as $InstDir\_MY_LINK to $InstDir\delete_me."
nsExec::ExecToStack 'mklink /D $InstDir\_MY_LINK $InstDir\delete_me'
Pop $0
Pop $1
DetailPrint "RegPrependString:Error=$0 (Should be 0)"
DetailPrint "$1"
SectionEnd
--- EDIT --------------------------------
Here's a full working example based on the accepted answer. This example creates a directory, a shortcut, and a link.
# ---
#
# This script tries to create a dir and a logical link.
#
# ---
RequestExecutionLevel admin
# includes
!include .\PrependEnv.nsh
# definitions
Outfile "009-exec-examples.exe"
InstallDir "C:\temp\nsis-examples\009-exe-examples"
ShowInstDetails show
Page Directory
Page InstFiles
# section to copy files and manipulate env variable
Section
# copy files
DetailPrint ""
DetailPrint "Copying files to $InstDir..."
DetailPrint ""
SetOutPath "$InstDir\resources"
File /a /r "resources\"
# create a dir
DetailPrint ""
DetailPrint "Making dir $InstDir\delete_me"
CreateDirectory $InstDir\delete_me
Pop $0
Pop $1
DetailPrint "RegPrependString:Error=$0 (Should be 0)"
DetailPrint "$1"
# create a short cut
DetailPrint ""
DetailPrint "Creating SHORTCUT as $InstDir\_MY_SHORTCUT to $InstDir\delete_me."
CreateShortCut $InstDir\_MY_SHORTCUT.lnk $InstDir\delete_me
Pop $0
Pop $1
DetailPrint "RegPrependString:Error=$0 (Should be 0)"
DetailPrint "$1"
# create a logical link
DetailPrint ""
DetailPrint "Creating LINK as $InstDir\_MY_SHORTCUT to $InstDir\delete_me."
nsExec::ExecToStack 'cmd.exe /C mklink /D $InstDir\_MY_LINK $InstDir\delete_me'
Pop $0
Pop $1
DetailPrint "RegPrependString:Error=$0 (Should be 0)"
DetailPrint "$1"
SectionEnd

For a directory, just use CreateDirectory. mklink is an internal command inside cmd.exe, you would have to execute cmd.exe /C mklink /D "c:\link" "c:\target".
Alternatively, call the API directly:
Section
!define /IfNDef SYMBOLIC_LINK_FLAG_DIRECTORY 1
System::Call 'KERNEL32::CreateSymbolicLink(t "c:\link", t "c:\target", i ${SYMBOLIC_LINK_FLAG_DIRECTORY})b.r0
DetailPrint Success=$0
SectionEnd

This worked to create a short cut (not a logical link):
# ---
#
# This script tries to create a dir and a logical link.
#
# ---
RequestExecutionLevel admin
# includes
!include .\PrependEnv.nsh
# definitions
Outfile "009-exec-examples.exe"
InstallDir "C:\temp\nsis-examples\009-exe-examples"
ShowInstDetails show
Page Directory
Page InstFiles
# section to copy files and manipulate env variable
Section
# copy files
DetailPrint ""
DetailPrint "Copying files to $InstDir..."
DetailPrint ""
SetOutPath "$InstDir\resources"
File /a /r "resources\"
# create a dir
DetailPrint ""
DetailPrint "Making dir $InstDir\delete_me"
CreateDirectory $InstDir\delete_me'
Pop $0
Pop $1
DetailPrint "RegPrependString:Error=$0 (Should be 0)"
DetailPrint "$1"
# create a logical link
DetailPrint ""
DetailPrint "Creating logical link as $InstDir\_MY_LINK to $InstDir\delete_me."
CreateShortCut $InstDir\_MY_LINK.lnk $InstDir\delete_me'
Pop $0
Pop $1
DetailPrint "RegPrependString:Error=$0 (Should be 0)"
DetailPrint "$1"
SectionEnd

Related

How can I use the following script?

I want to delete all files except the Bookmarks file from the Default folder. But the following code does not work. I know I should use the Batch file, but is there a way to use the code below? Thank you for any help
ExecWait '"$SYSDIR\cmd.exe" /c "SET "sourcedir=$LOCALAPPDATA\Google\Default" & SET "keepfile=Bookmarks" & FOR %a IN ("%sourcedir%*") DO IF /i NOT "%~nxa"=="%keepfile%" DEL "%a""'
Section "Prepare example"
SetOutPath "$LOCALAPPDATA\Google\Default"
SetOverwrite off
File "/oname=$outdir\Bookmarks" "${__FILE__}"
File "/oname=$outdir\Blah" "${__FILE__}"
File "/oname=$outdir\Footmarks" "${__FILE__}"
SectionEnd
!include LogicLib.nsh
Section
StrCpy $2 "$LOCALAPPDATA\Google\Default"
FindFirst $0 $1 "$2\*"
loop:
StrCmp $1 "" done
StrCmp $1 . next
StrCmp $1 .. next
${If} $1 != "Bookmarks"
Delete "$2\$1"
${EndIf}
next:
FindNext $0 $1
Goto loop
done:
FindClose $0
SectionEnd

Read And Update JSON File Using nsJSON Plugin (NSIS)

I am trying to update one data on JSON file using nsJson Plugin.
My JSON data on File
{ "header_left_lebel": "LEFT LEBEL",
"header_center_label": "CENTER LEBEL",
"base_path": "E:\Workspace\my-demo-app"
}
I want to edit the base path during installation of the application.
My Code to Read and Update the Value
Section "Installation Section"
SetOutPath "$INSTDIR"
GetFullPathName $0 ..
StrCpy $installationPath "$0\${applicationName}";This Holds the installation path
nsJSON::Set /file `$installationPath/config/settings.json`
nsJSON::Set `base_path` /value `"$installationPath"`
nsJSON::Serialize /file `$installationPath/config/settings.json`
WriteUninstaller "$INSTDIR\Uninstall.exe"
SectionEnd
The above code updates the JSON file but it only keeps base_path
I want to keep all the data and only to update base_path
Any help or links will be appreciated.
Your code works correctly for me when using NSIS v3.04 and JSON plug-in v1.1.1.0 (November 2017):
Unicode True
!macro DumpTxtFile file
Push "${file}"
Call DumpTxtFile
!macroend
Function DumpTxtFile
Exch $0
Push $1
FileOpen $0 $0 r
loop:
ClearErrors
FileRead $0 $1
IfErrors done
DetailPrint $1
Goto loop
done:
FileClose $0
Pop $1
Pop $0
FunctionEnd
!include LogicLib.nsh
Section
FileOpen $0 "$temp\NSIStest.json" w
FileWrite $0 '{ "header_left_lebel": "LEFT LEBEL",$\r$\n'
FileWrite $0 ' "header_center_label": "CENTER LEBEL",$\r$\n'
FileWrite $0 ' "base_path": "E:\Workspace\my-demo-app"$\r$\n'
FileWrite $0 '}'
FileClose $0
!insertmacro DumpTxtFile "$temp\NSIStest.json"
Var /Global installationPath
StrCpy $installationPath "c:\dummy\path"
ClearErrors
nsJSON::Set /file `$temp\NSIStest.json`
nsJSON::Set `base_path` /value `"$installationPath"`
nsJSON::Serialize /format /file `$temp\NSIStest.json`
${If} ${Errors}
Abort "Unable to update JSON file!"
${EndIf}
!insertmacro DumpTxtFile "$temp\NSIStest.json"
SectionEnd

NSIS Inetc get: can I make the downloaded file a variable?

The code is working when I have File_1234.exe added there. But the file name changes and download.php redirects to the exe. So instead of having a fixed file name there, I would like to have a code where i don't need to specify file name.
Is it possible to replace the first File_1234.exe with code to download whatever file the URL gives, and therefore to replace the second File_1234.exe with code that would run (ExecShell) this downloaded file?? Thanks
The code itself is here:
Section "File"
inetc::get "http://example.com/download.php" "$pluginsdir\File_1234.exe"
Pop $0
DetailPrint "Result: $R0"
ExecShell "" '"$pluginsdir\File_1234.exe"'
SectionEnd
INetC does not have a flag that passes the INTERNET_FLAG_NO_AUTO_REDIRECT flag to WinInet so there is no way to do a head request and find the location when the server returns a 30x redirection code.
If you can modify download.php to just return the final URL as a small text file when a special parameter is present then you can make two GET requests, the first to get the name and the second to do the main download:
Section
InitPluginsDir
StrCpy $0 "http://example.com/download.php?fileid=1234"
inetc::get /SILENT "$0&locationonly=1" "$PluginsDir\location.txt" /END
FileOpen $1 "$PluginsDir\location.txt" R
FileRead $1 $2
FileClose $1
StrLen $1 $2
loop:
IntOp $1 $1 - 1
StrCpy $3 $2 1 $1
StrCmp $3 '/' 0 +4
IntOp $1 $1 + 1
StrCpy $3 $2 "" $1
Goto +2
StrCmp $3 "" 0 loop
StrCmp $3 "" nofilename
inetc::get "$0" "$PluginsDir\$3" /END
Goto done
nofilename:
MessageBox mb_iconstop "Unable to parse filename from $2"
done:
SectionEnd
This example assumes that http://example.com/download.php?fileid=1234 would download the file but http://example.com/download.php?fileid=1234&&locationonly=1 would only return a URL like http://example.com/myfiles/whatever.exe
This is a 5 year later answer to help who ever might want to know how to get inetc::get output into a variable ;)
Obviously you found a solution since then... anyway:
inetc::get has a nice option /TOSTACK that does this.
Here's how on your example:
!include LogicLib.nsh
Section "File"
inetc::get /TOSTACK "http://example.com/download.php" ""
Pop $0
DetailPrint "Result: $0"
${If} $0 == 'OK'
Pop $0
StrCpy $filename $0
inetc::get /TOSTACK "http://example.com/$filename" "$PluginsDir\$filename"
Pop $0
${If} $0 == 'OK'
ExecShell "" '"$pluginsdir\$filename"'
${Else}
MessageBox MB_OK "Cannot download file $filename"
${EndIf}
${Else}
MessageBox MB_OK "Cannot fetch filename to download"
${EndIf}
SectionEnd
This is possible if your "http://example.com/download.php" returns URL of file to download.
What I mean: download.php returns URL as text ("http://example.com/file_12345.exe").
1) This text is downloaded with inetc to some local file and read into variable.
2) Use Inetc to download the file from URL (specified in variable) again as a resulting .exe file.
Is this acceptable for you?

Why is temporary file not deleted in NSIS?

I have compared two files and stored mismatched values in the temporary file. I have referred to this link. After that read the values from temporary file and replaced in original file. Finally I have tried to delete temporary file. All the process working fine except temporary file deletion.
I have used following code:
page custom twofilecompare
page custom originalwrite
Function twofilecompare
FileOpen $0 "$INSTDIR\backup.properties" "r"
FileOpen $1 "$INSTDIR\orginal.properties" "r"
#IfFileExists "$INSTDIR\temp.properties" 0 +1
#Delete /REBOOTOK "$INSTDIR\temp.properties"
FileOpen $R0 "$INSTDIR\temp.properties" "w"
ClearErrors
loop:
FileRead $0 $2
${If} $2 == "$\r$\n"
Goto loop
${EndIf}
FindClose $0
FileRead $1 $3
IfErrors done
strcmp $2 $3 loop here
here:
FileWrite $R0 $2
Goto loop
done:
FileClose $0
FileClose $1
FileClose $R0
FunctionEnd
Function originalwrite
IfFileExists "$INSTDIR\temp.properties" 0 filenotfound
FileOpen $0 "$INSTDIR\temp.properties" "r"
loop:
FileRead $0 $1
IfErrors done
//do some stuff
done:
**IfFileExists "$INSTDIR\resource\temp.properties" 0 filenotfound
Delete /REBOOTOK "$INSTDIR\temp.properties"**
filenotfound:
MessageBox MB_OK "file not found"
FunctionEnd
Even I cant able modify these three files[temp,backup,original] manually also.If i modify and click save prompt message displayed as "please check if this file opened another program"
I have also used file closed after file usage as completed.
Even i have tried this code also
Function .onInstSuccess
IfFileExists "$INSTDIR\temp.properties" notfound
MessageBox MB_OK "file exists"
Delete /REBOOTOK $INSTDIR\temp.properties
Goto done
notfound:
MessageBox MB_OK "file not found"
Done:
MessageBox MB_OK "file deleted"
FunctionEnd
But the temporary file is not deleted. How to delete temporary this file?
Can someone help me?
Thanks in advance
The originalwrite function is missing FileClose
Are you requesting admin rights in your script?
RequestExecutionLevel admin
Some applications like Notepad++ will display a "please check if this file opened another program" message if you try to edit a file that needs admin rights to edit (such as a text file in C:\Program Files).

NSIS Find all .txt files

I currently have a check to find all text files in $INSTDIR, shown below.
However, there could potentially be subdirectories, such as $INSTDIR\mySub, which contains additional .txt files. Is there a way to keep a similar loop structure but search all subdirectories as well?
FindFirst $R0 $R1 "$INSTDIR\*.txt"
IfErrors ExitInstaller 0
LoopIt:
Messagebox MB_OK "Do some processing on $R1"
FindNext $R0 $R1
IfErrors 0 LoopIt
Function ProcessTextFiles
Exch $0
Push $1
Push $2
FindFirst $1 $2 "$0\*.txt"
loop:
IfErrors end
DetailPrint 'Found "$0\$2"'
FindNext $1 $2
goto loop
end:
FindClose $1
FindFirst $1 $2 "$0\*.*"
dirloop:
IfErrors dirend
IfFileExists "$0\$2\*.*" 0 dirnext
StrCmp $2 "." dirnext
StrCmp $2 ".." dirnext
Push "$0\$2"
call ${__FUNCTION__}
dirnext:
FindNext $1 $2
goto dirloop
dirend:
FindClose $1
Pop $2
Pop $1
Pop $0
FunctionEnd
section
push "$InstDir"
call ProcessTextFiles
sectionend
Try to use the Locate function instead -- it could be much better solution. You can write options to find with (or without) subdirectories, define mask and so on. See http://nsis.sourceforge.net/Locate for doc and examples.

Resources