I have an existing Route53 record that I'm attempting to import. Example of the record: 50200._dkey.mydomain.com
I create the resource like so:
resource "aws_route53_record" "50200_dkey_txt" {
zone_id = aws_route53_zone.mydomain_com.zone_id
name = "50200._dkey.mydomain.com"
type = "TXT"
ttl = "300"
records = ["text_record_contents"]
}
Then, I run the import:
terraform import module.route53.aws_route53_record.50200_dkey_txt Z0N3ID0FZ0NE_50200._dkey.mydomain.com_TXT
I'm greeted with the following error:
╷
│ Error: Attribute name required
│
│ on <import-address> line 1:
│ 1: module.route53.aws_route53_record.50200_dkey_txt
│
│ Dot must be followed by attribute name.
╵
I'm assuming the underscore in the record is the culprit. If I'm correct in assuming so, is there a way to escape the underscore character or format it in such way to make terraform read it in literal form? I attempted to wrap it in single quotes, but received the same error.
Terraform does not allow a resource name that starts with a digit, because when referring to resources elsewhere in the module and on the command line Terraform (similar to many other languages) treats a digit as the start of a number, rather than as the start of a name.
Normally Terraform would catch this when parsing your configuration, but I think because you are using terraform import as your first command to run here it's the command line parsing that is coming first, and therefore unfortunately raising a less helpful error.
This is what other Terraform commands would've shown, due to the configuration being invalid:
╷
│ Error: Invalid resource name
│
│ on example.tf line 1, in resource "aws_route53_record" "50200_dkey":
│ 1: resource "aws_route53_record" "50200_dkey" {
│
│ A name must start with a letter or underscore and may contain only letters,
│ digits, underscores, and dashes.
╵
The solution then is to change the resource name to be a valid name, such as by adding some letters to the start of it as a prefix:
resource "aws_route53_record" "txt_50200_dkey" {
# ...
}
Then when you run terraform import you should specify the new resource name, but you should be able to keep the same remote identifier (the second argument) so that Terraform will bind the given remote object to the given local address:
terraform import "module.route53.aws_route53_record.txt_50200_dkey" "Z0N3ID0FZ0NE_50200._dkey.mydomain.com_TXT"
(I'm actually not sure how aws_route53_record in particular interprets its "remote ID" strings, so I've just copied what you tried verbatim here. With the invalid resource name fixed this may expose a new error about the ID string, but I probably won't know the answer to that one if so. 😬)
The import command is slightly off. It should be:
terraform import module.route53.aws_route53_record.50200_dkey Z0N3ID0FZ0NE_50200._dkey.mydomain.com_TXT
Note the form for the namespace is <optional module>.<optional module declared name>.<resource type>.<resource name>["<optional iterator key>"].
Related
I am new to Terraform and I am writing a script. Following is my directory structure
folder
---.terraform
---..terraform.lock.hcl
---main.tf
---terraform.tfvars
---variables.tf
Following is my content on terraform.tfvars.
environment = "development"
Following is my content on main.tf.
tags = {
environment = var.environment
}
But the values are not updating. Following is the error:
╷
│ Warning: Value for undeclared variable
│
│ The root module does not declare a variable named "environment" but a value was found in file "terraform.tfvars". If you meant to use this value, add a "variable" block to the configuration.
│
│ To silence these warnings, use TF_VAR_... environment variables to provide certain "global" settings to all configurations in your organization. To reduce the verbosity of these warnings, use the
│ -compact-warnings option.
╵
╷
│ Warning: Value for undeclared variable
│
│ The root module does not declare a variable named "admin_username" but a value was found in file "terraform.tfvars". If you meant to use this value, add a "variable" block to the configuration.
│
│ To silence these warnings, use TF_VAR_... environment variables to provide certain "global" settings to all configurations in your organization. To reduce the verbosity of these warnings, use the
│ -compact-warnings option.
╵
╷
│ Warning: Values for undeclared variables
│
│ In addition to the other similar warnings shown, 1 other variable(s) defined without being declared.
╵
╷
│ Error: Reference to undeclared input variable
│
│ on main.tf line 22, in resource "azurerm_resource_group" "tf_example_rg":
│ 22: environment = var.environment
│
│ An input variable with the name "environment" has not been declared. This variable can be declared with a variable "environment" {} block.
As I am using terraform.tfvars I don't need to give the filename on CLI. I think I am doing everything right but it's yet not working.
You have to actually declare your variable using variable block. For example:
variable "environment" {}
If you have such declarations, you have to double check the spelling and locations of them.
#AunZaidi , As stated in the error messages terraform can not find the defined variables.
The root module does not declare a variable named "environment" but a value was found in file "terraform.tfvars". If you meant to use this value, add a "variable" block to the configuration.
I would recommend you to take a look at the terraform-azure-tutorials to get acquainted with the basics.
you can solve your issue by just defining a new variable using syntax
variable "environment" {
type = string
description = "(optional) Environment for the deployment"
}
Refer to https://developer.hashicorp.com/terraform/language/values/variables#arguments for definitions of the arguments used in terraform variables.
Also one of the recommended practices is to use a dedicated file variables.tf for all the variables inputs required in your terraform code.
I'm testing a Terraform module using Terratest. One of the input variables to the module is supposed to be the contents of a config file (so that the templatefile function can be used). This module under test is intended to be used as the source for other modules and thus I don't have too much flexibility to change it around.
The basic structure of the inputs for this module in Go for terratest is this
terraformOptions: &terraform.Options{
Vars: map[string]interface{}{
"sidecars": map[string]interface{}{
"envoy": map[string]interface{}{
"config_data": envoyConfigString,
...
The config_data field is the one causing issues. Right now I'm reading the file data in using Go's ioutil.ReadFile and converting it to a string. However, when the terratest runs the tests I get the following errors
│ Error: Invalid multi-line string
│
│ on line 1:
│ (source code not available)
│
│ Quoted strings may not be split over multiple lines. To produce a
│ multi-line string, either use the \n escape to represent a newline
│ character or use the "heredoc" multi-line template syntax.
╵
╷
│ Error: Unterminated template string
│
│ on line 1:
│ (source code not available)
│
│ No closing marker was found for the string.
How to I pass multi-line file data through the Vars field?
I have a configuration which uses modules, this is its structure:
main.tf
\modules
\kubernetes_cluster
\main.tf
\variables.tf
At this stage I had no separate tfvars file, I relied on default values declared in the variables.tf file, and this worked fine. I then decided to create a tfvars file resulting in:
main.tf
\modules
\kubernetes_cluster
\main.tf
\variables.tf
\variables.tfvars
At the same time I removed the default values from variables file, then when I ran:
terraform apply -target=module.kubernetes_cluster -auto-approve
I got errors complaining that I needed to pass my variables in as arguments due to the fact "They were missing", so I moved to this:
main.tf
variables.tf
variables.tfvars
\modules
\kubernetes_cluster
\main.tf
\variables.tf
this is what main.tf in the root module looks like:
module "kubernetes_cluster" {
source = "./modules/kubernetes_cluster"
kubernetes_version = var.kubernetes_version
node_hosts = var.node_hosts
}
When I run terraform apply I get prompted for the values of the variables. All I want to do is not rely on variable default values and to be able to run terraform apply from the root module directory without having to pass in variable values by hand, I suspect that my module structure somewhere along the line is not correct.
If you want to have TF load tfvars automatically, the file must be called terraform.tfvars, not variables.tfvars. There are other possibilities:
Terraform also automatically loads a number of variable definitions files if they are present:
Files named exactly terraform.tfvars or terraform.tfvars.json.
Any files with names ending in .auto.tfvars or .auto.tfvars.json.
As per the documentation, terraform automatically loads tfvars if:
Either variable file name is terraform.var or terraform.var.json
Or YOUR_NAME.auto.tfvar
So in your case renaming variables.tfvars to variables.auto.tfvars would work
I have the following directory Structure:
.
├── ./first_terraform.tf
├── ./modules
│ └── ./modules/ssh_keys
│ ├── ./modules/ssh_keys/main.tf
│ ├── ./modules/ssh_keys/outputs.tf
│ └── ./modules/ssh_keys/variables.tf
├── ./terraform.auto.tfvars
├── ./variables.tf
I am trying to pass a variable ssh_key to my child module defined as main.tf inside ./modules/ssh_keys/main.tf
resource "aws_key_pair" "id_rsa_ec2" {
key_name = "id_rsa_ec2"
public_key = file(var.ssh_key)
}
I also have this variable defined both at root and child level variables.tf file. For the value, I have set it in terraform.auto.tfvars as below
# SSH Key
ssh_key = "~/.ssh/haha_key.pub"
I also have a variable defined in root level and child level variables.tf file:
variable "ssh_key" {
type = string
description = "ssh key for EC2 login and checks"
}
My root terraform configuration has this module declared as:
module "ssh_keys" {
source = "./modules/ssh_keys"
}
I first did a terraform init -upgrade on my root level. Then ran terraform refresh and got hit by the following error.
Error: Missing required argument
on first_terraform.tf line 69, in module "ssh_keys":
69: module "ssh_keys" {
The argument "ssh_key" is required, but no definition was found.
Just for reference, line 69 in my root level configuration is where the module declaration has been made. I don't know what I have done wrong here. It seems I have all the variables declared, so am I missing some relationship between root/child module variable passing etc.?
Any help is appreciated! Thanks
I Think I know what I did wrong.
Terraform Modules - as per the documentation requires parents to pass on variables as part of invocation. For example:
module "foo" {
source = "./modules/foo"
var1 = value
var2 = value
}
The above var1, var2 can come from either auto.tfvars file, environment variables (recommended) or even command line -var-file calls. In fact, this is what Terraform calls "Calling a Child Module" here
Once I did that, everything worked like a charm! I hope I did find the correct way of doing things.
My terraform project layout looks something like:
[project root dir]
main.tf
- my_module [directory]:
variables.tf
my_instance.tf
In variables.tf I have something like this:
variable "foo-ami" {
default = "ami-12345"
description = "Super awesome AMI"
}
In my_instance.tf I reference it like so:
resource "aws_instance" "my_instance" {
ami = "${var.foo-ami}"
...
}
If I want to override this variable from the command line, the docs here seem to suggest I should be able to run the following command from the top level (main.tf) location:
terraform plan -var 'foo-ami=ami-987654'
However, the variable switch doesn't seem to be getting picked up. The old value remains set. Further more if I remove the default setting I get an error from terraform saying it's not set, so clearly the -var switch isn't being picked up.
Thoughts?
TIA
The variables of root and my_module are different. If you want to pass a variable to my_module, you need to specify it.
In the main.tf, you should set the variable as follows:
variable "foo-ami" {}
module "my_module" {
source = "./my_module"
foo-ami = "${var.foo-ami}"
...
}
For details of the module feature refer to the following documents:
https://www.terraform.io/docs/modules/usage.html