In my controller I have imported the secure util file when I call that util with path as parameter it returns unique Id. but how to call this function in test file using proxyquire and stub.
controller.ts
import { getSecret } from './util/secrect-util'
export function getId(req: Request, res: Response) {
const path='test/path'
const uniueID = getSecret(path);
console.log(uniueID) // prints testUser01
const url=`https://mytest.com?userid=${uniueID}`;
res.redirect(302,url);
}
test.ts
import { Request, Response } from "express";
import * as sinon from 'sinon';
import * as proxyquire from 'proxyquire';
describe('should redirect', () => {
const validurl:string="https://mytest.com?userid=testUser01";
let res:any;
let req:any
beforeEach(() => {
res = {
redirect:sinon.stub()
}
});
it('should get error with invalid path', () => {
const secPath = sinon.stub().returns('/test/invalidPath');
const urlctl = proxyquire('./controller', {
getSecret: { path: secPath },
});
urlctl.getId(req, res);
sinon.assert.calledWithExactly(
res.redirect,
400,
'inValidpath',
)
});
});
getting error while run the test cases. Please assist.
From the doc:
proxyquire({string} request, {Object} stubs)
request: path to the module to be tested e.g., ../lib/foo
stubs: key/value pairs of the form { modulePath: stub, ... }
module paths are relative to the tested module not the test file
therefore specify it exactly as in the require statement inside the tested file
values themselves are key/value pairs of functions/properties and the appropriate override
E.g.
controller.ts:
import { getSecret } from './util/secrect-util';
import { Request, Response } from 'express';
export function getId(req: Request, res: Response) {
const path = 'test/path';
const uniueID = getSecret(path);
console.log(uniueID);
const url = `https://mytest.com?userid=${uniueID}`;
res.redirect(302, url);
}
util/secrect-util.ts:
export function getSecret(path) {
return 'real implementation';
}
controller.test.ts:
import sinon from 'sinon';
import proxyquire from 'proxyquire';
describe('70666283', () => {
it('should pass', () => {
const getSecretStub = sinon.stub().returns('123');
const urlctl = proxyquire('./controller', {
'./util/secrect-util': {
getSecret: getSecretStub,
},
});
const req = {};
const res = { redirect: sinon.stub() };
urlctl.getId(req, res);
sinon.assert.calledWithExactly(getSecretStub, 'test/path');
sinon.assert.calledWithExactly(res.redirect, 302, 'https://mytest.com?userid=123');
});
});
Test result:
70666283
123
✓ should pass (1743ms)
1 passing (2s)
------------------|---------|----------|---------|---------|-------------------
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
------------------|---------|----------|---------|---------|-------------------
All files | 88.89 | 100 | 50 | 88.89 |
70666283 | 100 | 100 | 100 | 100 |
controller.ts | 100 | 100 | 100 | 100 |
70666283/util | 50 | 100 | 0 | 50 |
secrect-util.ts | 50 | 100 | 0 | 50 | 2
------------------|---------|----------|---------|---------|-------------------
Related
In controller I am redirecting to another url with query params as a state. State is nothing but random UUID. Like given below the controller.
test.controller.ts
import {Request,Response} from "express";
import {v4 as uuid} from "uuid";
export function test(req:Request,res:Response){
const state=uuid();
console.log(state) // 110ec58a-a0f2-4ac4-8393-c866d813b8d1
if(true){
const url=`https://testurl/user?state=${state}`;
res.redirect(302,url);
}
}
and the unit test file like below
test.controller.spec.ts
import {Request,Response} from "express";
import * as sinon from 'sinon';
import {expect} from 'chai';
import * as proxyquire from 'proxyquire';
descripbe('shoud redirect',()=>{
const validurl:string="https://testurl/user?state=110ec58a-a0f2-4ac4-8393-c866d813b8d1";
let res:any;
let req:any
let resstub:{calledWith:any};
beforeEach(()=>{
res={
redirect:()=>{}
}
resstub = sinon.stub(res,'redirect');
});
it('should redirect with valid url',()=>{
const urlctl=proxyquire('test-contriller',{});
urlctl.test(req,res);
expect(resstub.calledWith(302,validurl)).to.be.true;
})
})
when I validate the redirectUrl part it's getting failed because the state value is chaining every time randomly. Can please assist how to do I validate
From the doc How to use Link Seams with CommonJS. We will be using proxyquire to construct our seams so that we can stub the v4 function exported from the uuid package.
controller.ts:
import { Request, Response } from 'express';
import { v4 as uuid } from 'uuid';
export function test(req: Request, res: Response) {
const state = uuid();
if (true) {
const url = `https://testurl/user?state=${state}`;
res.redirect(302, url);
}
}
controller.test.ts:
import sinon from 'sinon';
import proxyquire from 'proxyquire';
describe('shoud redirect', () => {
let res: any;
let req: any;
beforeEach(() => {
res = { redirect: sinon.stub() };
});
it('should redirect with valid url', () => {
const uuidv4Stub = sinon.stub().returns('110ec58a-a0f2-4ac4-8393-c866d813b8d1');
const urlctl = proxyquire('./controller', {
uuid: { v4: uuidv4Stub },
});
urlctl.test(req, res);
sinon.assert.calledWithExactly(
res.redirect,
302,
'https://testurl/user?state=110ec58a-a0f2-4ac4-8393-c866d813b8d1',
);
});
});
test result:
shoud redirect
✓ should redirect with valid url (1592ms)
1 passing (2s)
---------------|---------|----------|---------|---------|-------------------
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
---------------|---------|----------|---------|---------|-------------------
All files | 100 | 50 | 100 | 100 |
controller.ts | 100 | 50 | 100 | 100 | 6
---------------|---------|----------|---------|---------|-------------------
There is code in our codebase like below:
#Validate(Param1)
async post(request, responseHandler) {
// some code
}
I Am trying to test the post function. But want to avoid evaluating the #Validate function. The Validate is a function in another module.
// validator.ts
export const Validate = () => {
// some code
}
How to? .
You could use jest.mock(moduleName, factory, options) create the mocked Validate decorator instead of using the real Validate decorator which may have a lot of validation rules.
E.g.
index.ts:
import { Validate } from './validator';
export class Controller {
#Validate('params')
async post(request, responseHandler) {
console.log('real post implementation');
}
}
validator.ts:
export const Validate = (params) => {
return (target: any, propertyKey: string, descriptor: TypedPropertyDescriptor<any>) => {
const oFunc = descriptor.value;
descriptor.value = function inner(...args: any[]) {
console.log('real validator decorator implementation');
// lots of validation
const rval = oFunc.apply(this, args);
return rval;
};
};
};
index.test.ts:
import { Validate } from './validator';
import { mocked } from 'ts-jest/utils';
jest.mock('./validator');
describe('63531414', () => {
afterAll(() => {
jest.resetAllMocks();
});
it('should pass', async () => {
mocked(Validate).mockImplementationOnce((params) => {
return (target: any, propertyKey: string, descriptor: TypedPropertyDescriptor<any>) => {
const oFunc = descriptor.value;
descriptor.value = function inner(...args: any[]) {
console.log('mocked validator decorator implementation');
const rval = oFunc.apply(this, args);
return rval;
};
};
});
const { Controller } = require('./');
const logSpy = jest.spyOn(console, 'log');
const ctrl = new Controller();
await ctrl.post({}, () => {});
expect(Validate).toBeCalledWith('params');
expect(logSpy).toBeCalledWith('real post implementation');
});
});
unit test result with coverage report:
PASS src/stackoverflow/63531414/index.test.ts (12.634s)
63531414
✓ should pass (154ms)
console.log node_modules/jest-mock/build/index.js:860
mocked validator decorator implementation
console.log node_modules/jest-mock/build/index.js:860
real post implementation
--------------|----------|----------|----------|----------|-------------------|
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s |
--------------|----------|----------|----------|----------|-------------------|
All files | 45.45 | 100 | 25 | 45.45 | |
index.ts | 100 | 100 | 100 | 100 | |
validator.ts | 14.29 | 100 | 0 | 14.29 | 2,3,4,5,7,8 |
--------------|----------|----------|----------|----------|-------------------|
Test Suites: 1 passed, 1 total
Tests: 1 passed, 1 total
Snapshots: 0 total
Time: 14.354s
source code: https://github.com/mrdulin/jest-codelab/tree/master/src/stackoverflow/63531414
I have my internal function
//in greatRoute.ts
async function _secretString(param: string): Promise<string> {
...
}
router
.route('/foo/bar/:secret')
.get(
async (...) => {
...
const secret = _secretString(res.params.secret);
...
},
);
export default {
...
_secretString
};
and now I'm trying to mock the call with sinon.stub like this:
sinon.stub(greatRoute, '_secretString').resolves('abc');
But that doesn't work the way I want it to. When i call the route in my test it still goes into the _secretString function. Am I missing something here? I already tried to put the export in front of the function header like this:
export async function _secretString(param: string): Promise<string>
instead of doing the export default {...} but that didn't help.
You can use rewire package to stub _secretString function. E.g.
index.ts:
async function _secretString(param: string): Promise<string> {
return 'real secret';
}
async function route(req, res) {
const secret = await _secretString(req.params.secret);
console.log(secret);
}
export default {
_secretString,
route,
};
index.test.ts:
import sinon from 'sinon';
import rewire from 'rewire';
describe('61274112', () => {
it('should pass', async () => {
const greatRoute = rewire('./');
const secretStringStub = sinon.stub().resolves('fake secret');
greatRoute.__set__('_secretString', secretStringStub);
const logSpy = sinon.spy(console, 'log');
const mReq = { params: { secret: '123' } };
const mRes = {};
await greatRoute.default.route(mReq, mRes);
sinon.assert.calledWithExactly(logSpy, 'fake secret');
sinon.assert.calledWith(secretStringStub, '123');
});
});
unit test results with coverage report:
fake secret
✓ should pass (1383ms)
1 passing (1s)
----------|---------|----------|---------|---------|-------------------
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
----------|---------|----------|---------|---------|-------------------
All files | 75 | 100 | 50 | 75 |
index.ts | 75 | 100 | 50 | 75 | 2
----------|---------|----------|---------|---------|-------------------
I am trying to stub the following :
let file = yaml.safeLoad(fsExtra.readFileSync(filepath, 'utf8'), err => {
logger.warn(err);
});
in a way that it get an err and run the logger.warn
but the problem is that when I do stubbing on either safeLoad or readFileSync with any of the following codes, it never reaches the logger.warn(err);
sinon.stub().throws() or sinon.stub().reject() or
sinon.stub().callsFake(() => {
throw new Error();
})
any idea?
Here is the solution, for simple, I create a fsExtra object to simulate the real node module.
index.ts:
export const logger = {
warn(message) {
console.warn(message);
}
};
export const yaml = {
safeLoad(file, callback) {}
};
export const fsExtra = {
readFileSync(filepath, options) {}
};
export function main() {
const filepath = './.tmp/sinon.js';
let file = yaml.safeLoad(fsExtra.readFileSync(filepath, 'utf8'), err => {
logger.warn(err);
});
}
index.spec.ts:
import { main, fsExtra, yaml, logger } from '.';
import sinon from 'sinon';
import { expect } from 'chai';
describe('main', () => {
it('should safeLoad error', done => {
const mError = new Error('fake error');
const warnSpy = sinon.spy(logger, 'warn');
const readFileSyncStub = sinon.stub<any, string>(fsExtra, 'readFileSync').returns('file content');
const safeLoadStub = sinon.stub(yaml, 'safeLoad').callsFake((content, callback) => {
callback(mError);
done();
});
main();
expect(readFileSyncStub.calledWith('./.tmp/sinon.js', 'utf8')).to.be.true;
expect(safeLoadStub.calledWith('file content', sinon.match.func));
expect(warnSpy.calledWith(mError)).to.be.true;
});
});
Unit test result with coverage report:
main
Error: fake error
at Context.<anonymous> (/Users/ldu020/workspace/github.com/mrdulin/mocha-chai-sinon-codelab/src/stackoverflow/58357977/index.spec.ts:1:3887)
at callFnAsync (/Users/ldu020/workspace/github.com/mrdulin/mocha-chai-sinon-codelab/node_modules/mocha/lib/runnable.js:415:21)
at Test.Runnable.run (/Users/ldu020/workspace/github.com/mrdulin/mocha-chai-sinon-codelab/node_modules/mocha/lib/runnable.js:357:7)
at Runner.runTest (/Users/ldu020/workspace/github.com/mrdulin/mocha-chai-sinon-codelab/node_modules/mocha/lib/runner.js:535:10)
at /Users/ldu020/workspace/github.com/mrdulin/mocha-chai-sinon-codelab/node_modules/mocha/lib/runner.js:653:12
at next (/Users/ldu020/workspace/github.com/mrdulin/mocha-chai-sinon-codelab/node_modules/mocha/lib/runner.js:447:14)
at /Users/ldu020/workspace/github.com/mrdulin/mocha-chai-sinon-codelab/node_modules/mocha/lib/runner.js:457:7
at next (/Users/ldu020/workspace/github.com/mrdulin/mocha-chai-sinon-codelab/node_modules/mocha/lib/runner.js:362:14)
at Immediate._onImmediate (/Users/ldu020/workspace/github.com/mrdulin/mocha-chai-sinon-codelab/node_modules/mocha/lib/runner.js:425:5)
at runCallback (timers.js:705:18)
at tryOnImmediate (timers.js:676:5)
at processImmediate (timers.js:658:5)
✓ should safeLoad error (46ms)
1 passing (55ms)
---------------|----------|----------|----------|----------|-------------------|
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s |
---------------|----------|----------|----------|----------|-------------------|
All files | 100 | 100 | 75 | 100 | |
index.spec.ts | 100 | 100 | 100 | 100 | |
index.ts | 100 | 100 | 60 | 100 | |
---------------|----------|----------|----------|----------|-------------------|
Source code: https://github.com/mrdulin/mocha-chai-sinon-codelab/tree/master/src/stackoverflow/58357977
I'm trying to stub function called on one of my routes in express Router with request from supertest library. I see that function foo is called correctly, unfortunately it is not replaced by stub function I wrote in test. Code is written in ES6 and I'm using babel-register and babel-polyfill to make it work.
I run testing script using
./node_modules/mocha/bin/mocha server --timeout 10000 --compilers js:babel-register --require babel-polyfill --recursive
router.js
import {foo} from '../controller';
const router = new Router();
router.route(ROUTE).post(foo);
controller.js
export function foo(req, res) {
res.status(200).send({
ok: 'ok'
});
}
test.js
import request from 'supertest';
import sinon from 'sinon';
import {app} from 'app';
import * as controller from 'controller';
const agent = request.agent(app);
describe('Admin routes tests', () => {
it('Tests login admin route', async () => {
const bar = () => {
console.log('bar');
};
sinon.stub(controller, 'foo', bar);
const req = await agent
.post(ROUTE)
.set('Accept', 'application/json');
console.log(stub.calledOnce); // false
});
});
Any help would be much appreciated.
Here is the solution:
app.js:
import express from "express";
import * as controller from "./controller";
const app = express();
app.post("/foo", controller.foo);
export { app };
controller.js:
export function foo(req, res) {
res.status(200).send({ ok: "ok" });
}
test.js:
import request from "supertest";
import sinon from "sinon";
import * as controller from "./controller";
import { expect } from "chai";
describe("Admin routes tests", () => {
it("Tests login admin route", (done) => {
const bar = () => {
console.log("bar");
};
const fooStub = sinon.stub(controller, "foo").callsFake(bar);
const { app } = require("./app");
const agent = request.agent(app);
agent
.post("/foo")
.set("Accept", "application/json")
.timeout(1000)
.end((err, res) => {
sinon.assert.calledOnce(fooStub);
expect(res).to.be.undefined;
expect(err).to.be.an.instanceof(Error);
done();
});
});
});
Since you stub foo controller and its return value is undefined. For supertest, there is no response, something like res.send(), the server will hang until the mocha test timeout and it will cause test failed.
.mocharc.yml:
recursive: true
require: ts-node/register
timeout: 2000
diff: true
inline-diffs: true
We add .timeout(1000) for supertest, because we know it will timeout(You stub the foo controller with bar). And, make an assertion for this timeout error.
Integration test result with coverage report:
Admin routes tests
bar
✓ Tests login admin route (1341ms)
1 passing (1s)
---------------|----------|----------|----------|----------|-------------------|
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s |
---------------|----------|----------|----------|----------|-------------------|
All files | 95.65 | 100 | 80 | 95.65 | |
app.ts | 100 | 100 | 100 | 100 | |
controller.ts | 50 | 100 | 0 | 50 | 2 |
test.ts | 100 | 100 | 100 | 100 | |
---------------|----------|----------|----------|----------|-------------------|
Source code: https://github.com/mrdulin/mocha-chai-sinon-codelab/tree/master/src/stackoverflow/41600031