Copy and pasting to a template and saving as new workbook - excel

Question

I'm trying to loop through and paste each different group of IDs into a template I have in a separate workbook. I then want it to save as a new workbook, using the Vendor Name in C1 of the second sheet in the new workbook.
But there's a few problems in me trying to complete this;
It is giving me an error at the SaveAs line.
The filename is not pulling from the cell I want.
It stops after the first loop.
Anybody have any ideas of what I need to fix?
Here is my current macro:
Option Explicit
SubNewBillback()
Dim wsBData, wsBackup, wsCreditMemo As Worksheet
Dim wb, wbTemplate, wbAllRebates As Workbook
Dim rngHeader As Range
Dim i As Long, n As Long, LastRow As Long, StartRow As Long
Dim InvNum, InvDate, VendName, VendNum, strPath, FileName, openfile As String
Dim Amt As Integer
strPath = "\\Billback Data Base-Spreadsheet\2021\September\Excel\"
openfile = "\\Billback Data Base-Spreadsheet\2021\September\BillbackAutoTemplate.xlsx"
Set wbAllRebates = ActiveWorkbook
With wbAllRebates
Set wsBData = .Sheets("BackupData")
Set wsBackup = .Sheets("Backup")
End With
'copy data from query
wsBData.Cells.Copy
wsBackup.Cells.PasteSpecial Paste:=xlPasteValues
StartRow = 2
Application.ScreenUpdating = False
'searches for change in ID#
With wsBackup
LastRow = .Range("A" & .Rows.Count).End(xlUp).Row
Set rngHeader = .Range("A1:O1")
For i = 2 To LastRow
' change ID next row
If .Cells(i, "A") <> .Cells(i + 1, "A") Then
' create new workbook
Set wbTemplate = Workbooks.Open(openfile)
.Range("A" & StartRow & ":O" & i).Copy wbTemplate.Sheets(2).Range("A2")
wbTemplate.SaveAs FileName:=strPath & Sheets(2).Cells(i, "C") & ".xlsx"
wbTemplate.Close True
' move to next
StartRow = i + 1
n = n + 1
End If
Next
End With
Application.ScreenUpdating = True
MsgBox n & " billbacks created."
End Sub

Answer 1

The function at the bottom will remove invalid characters from your file name. I've added the call to the function in your Save As line in your original code. It will replace any of the following characters in the vendor name : \ / ? | * [ ] { } < > ~ " # % & with a _. If you would rather it replace it with something else just change the "_" in the line sFileName = Replace(sFileName, Mid(vInval, i, 1), "_") to some other valid character
Option Explicit
Sub NewBillback()
Dim wsBData, wsBackup, wsCreditMemo As Worksheet
Dim wb, wbTemplate, wbAllRebates As Workbook
Dim rngHeader As Range
Dim i As Long, n As Long, LastRow As Long, StartRow As Long
Dim InvNum, InvDate, VendName, VendNum, strPath, FileName, openfile As String
Dim Amt As Integer
strPath = "\\Billback Data Base-Spreadsheet\2021\September\Excel\"
openfile = "\\Billback Data Base-Spreadsheet\2021\September\BillbackAutoTemplate.xlsx"
Set wbAllRebates = ActiveWorkbook
With wbAllRebates
Set wsBData = .Sheets("BackupData")
Set wsBackup = .Sheets("Backup")
End With
'copy data from query
wsBData.Cells.Copy
wsBackup.Cells.PasteSpecial Paste:=xlPasteValues
StartRow = 2
Application.ScreenUpdating = False
'searches for change in ID#
With wsBackup
LastRow = .Range("A" & .Rows.Count).End(xlUp).Row
Set rngHeader = .Range("A1:O1")
For i = 2 To LastRow
' change ID next row
If .Cells(i, "A") <> .Cells(i + 1, "A") Then
' create new workbook
Set wbTemplate = Workbooks.Open(openfile)
.Range("A" & StartRow & ":O" & i).Copy wbTemplate.Sheets(2).Range("A2")
wbTemplate.SaveAs FileName:=strPath & ValidateFileName(Sheets(2).Cells(i, "C")) & ".xlsx"
wbTemplate.Close True
' move to next
StartRow = i + 1
n = n + 1
End If
Next
End With
Application.ScreenUpdating = True
MsgBox n & " billbacks created."
End Sub
Function ValidateFileName(ByVal sFileName As String) As String
Dim vInval As String
Dim i As Long
vInval = ":\/?|*[]{}<>~""#%&" & Chr(10) & Chr(13)
For i = 1 To Len(vInval)
sFileName = Replace(sFileName, Mid(vInval, i, 1), "_")
Next i
ValidateFileName = sFileName
End Function