Excel vba for each range and split problem - excel

Question

Please help to solve my problem.
I use below script but result nothing on activesheet..
Sub Dutylist()
Dim dutyTable(1 To 2, 1 To 4) As String
Dim Cyc As Integer, Team As Integer
Dim Svalue As Range, Srange As Range
Dim Result() As String
//Cycle 1
dutyTable(1, 1) = "A,B,C,D,E,F,G"
dutyTable(1, 2) = "D,C,A,B,A,E,D"
dutyTable(1, 3) = "B,A,E,C,B,D,E"
dutyTable(1, 4) = "C,B,C,D,C,A,A"
//Cycle 2
dutyTable(2, 1) = "B,E,D,A,D,B,A"
dutyTable(2, 2) = "B,A,E,C,C,D,B"
dutyTable(2, 3) = "D,C,A,B,B,E,B"
dutyTable(2, 4) = "E,A,B,D,A,C,D"
Cyc = 1
Set Srange = ActiveSheet.Range("a:a")
For Team = 1 To 4
Result = Split(dutyTable(Cyc, Team), ",")
For Each Svalue In Srange
If Svalue = "Team " & CStr(Team) Then
Svalue.Offset(0, 1).Resize(, UBound(Result) + 1).Value = Result
End If
Next Svalue
Next Team
End Sub
Any problem of my code above?

Answer 1

My understanding for your code execution should be as following, what I have changed is rearrange the Looping with some modification and also you should set range by reference to last used row instead of A:A to speed up the execution.
Basically the code will match the value on Col A for the Team, if found then return dutyTable1 value based on the cycle give by you,
Sub Dutylist()
Dim dutyTable(1 To 2, 1 To 4) As String
Dim Cyc As Integer, Team As Integer
Dim Svalue As Range, Srange As Range
Dim Result() As String
Dim i As Long
dutyTable(1, 1) = "A,B,C,D,E,F,G"
dutyTable(1, 2) = "D,C,A,B,A,E,D"
dutyTable(1, 3) = "B,A,E,C,B,D,E"
dutyTable(1, 4) = "C,B,C,D,C,A,A"
dutyTable(2, 1) = "B,E,D,A,D,B,A"
dutyTable(2, 2) = "B,A,E,C,C,D,B"
dutyTable(2, 3) = "D,C,A,B,B,E,B"
dutyTable(2, 4) = "E,A,B,D,A,C,D"
Cyc = 1
Set Srange = ActiveSheet.Range("a1:a20")
For Each Svalue In Srange
For Team = 1 To 4
Result = Split(dutyTable(Cyc, Team), ",")
If InStr(Svalue.Value, Team) > 0 Then
Svalue.Offset(0, 1).Resize(, UBound(Result) + 1).Value = Result
End If
Next Team
Next Svalue
End Sub
Output (Only 3 Team are tested, can be extended)