Split invoice in pdf and excel - excel

Question

I have an invoice in MS access table and the invoice needs to be split according to the subsidiary field.
Private Sub CreateInv()
Dim i As Integer
Set db = CurrentDb
Set rs = db.OpenRecordset("tbl_result")
Set rs1 = db.OpenRecordset("tbl_result")
Do While rs.EOF = False
i = rs1![Subsidiary]
If rs1![Subsidiary] = "1025" Then Workbooks.Open CurrentProject.Path & "\Temp1025.xlsx"
If rs1![Subsidiary] = "1028" Then Workbooks.Open CurrentProject.Path & "\Temp1028.xlsx"
'Fill Invoice
Range("B2") = rs1![invno]
Range("C2") = rs1![vendorid]
Range("D2") = rs1![Subsidiary]
Range("E2") = rs1![InvDate]
rs1.MoveNext
If rs1.EOF = True Then GoTo Jumper
Jumper:
ActiveWorkbook.SaveAs "c:\users\nkumar\desktop\" & "sub2.xlsx"
excel.Application.DisplayAlerts = False
ActiveWorkbook.Close False
excel.Application.Quit
'excel.Application.DisplayAlerts = True
rs.MoveNext
'x = 0
If rs1.EOF = True Then Exit Sub
Loop
End Sub
Logic / Expected Output -> I have created two templates in excel. If the subsidiary is 1025 then write invoice details (table data) to Temp1025 excel file and if the subsidiary is 1028 then write invoice details (table data) to Temp1028 excel file.
Your assistance is much appreciated. Thank you in advance,
Nirmal

Answer 1

Should look something like this (untested, since I don't have Access):
Private Sub CreateInv()
Dim Db, s, rs As Object, xlApp As Object, wb As Object
Set Db = CurrentDb
Set xlApp = CreateObject("Excel.Application")
xlApp.Visible = True
For Each s In Array("1025", "1028")
'select only the records for this id
Set rs = Db.OpenRecordset("select t.invno, t.vendorid, t.subsidiary, t.invdate " & _
" from tbl_result t where t.subsidiary='" & s & "'")
'if there are records retrieved then write to Excel template
If Not rs.EOF Then
'open template based on subsidiary name
Set wb = xlApp.Workbooks.Open(CurrentProject.Path & "\Temp" & s & ".xlsx")
wb.Sheets(1).Range("B2").CopyFromRecordset rs 'write all records
wb.SaveAs "c:\users\nkumar\desktop\Sub_" & s & ".xlsx"
wb.Close False
End If
rs.Close
Next s
xlApp.Quit 'close Excel
End Sub