VBA searching for data across workbooks - excel

Question

I am working as a Data Analyst for a software startup where I am required to write macros to analyse and sort data more efficiently. I am currently working on a macro that takes a value one workbook ("Job MMRF") and searches for it in another ("U100 Material Information"). My code is as follows:
Sub MMRFValidation()
Dim c As Range
Dim leadtime As Double
Dim price As Double
Application.ScreenUpdating = False
With Workbooks("Job MMRF.csv")
For Each c In Range("C:C")
If c.Value = "" Then
c.Offset(, -2).Font.Color = vbRed
c.Offset(, 9).Value = "Need to contact vendor"
c.Offset(, 10).Value = "Need to contact vendor"
Else
Dim a As Range
With Workbooks("U100 Material Information.xlsx")
For Each a In Range("A:A")
If a.Value = c.Value Then
price = a.Offset(, 15).Value
leadtime = a.Offset(, 13).Value
End If
Next a
End With
If price = 0.01 And leadtime = 21 Then
c.Offset(, -2).Font.ColorIndex = 7
c.Offset(, 9).Value = leadtime
c.Offset(, 10).Value = price
Else
c.Offset(, -2).Font.Color = vbGreen
c.Offset(, 9).Value = leadtime
c.Offset(, 10).Value = price
End If
End If
Next c
End With
Application.ScreenUpdating = True
End Sub
c is the value from the first workbook. I am trying to find c in the second workbook. If it is found, I want to copy the values from the 13th and 15th column in the U100 wb (associated with the row where c was found) and paste these values into the 9th and 10th row in JobMMRF (associated with the row where c initially was). The part of the code that changes font color works, but the price/lead time part does not. Pls help, thanks.
edit: I have updated the code. Now it pulls price and leadtime values, but for some reason they are always 0.
Sample data

Answer 1

I've refactored your code.
Read the comments and adjust it to fit your needs
EDIT: I have modified the way it's handled the cases where the csv cell value is different than an empty string.
Code:
Sub MMRFValidation()
Dim csvWorkbook As Workbook
Dim csvSheet As Worksheet
Dim csvRange As Range
Dim csvcell As Range
Dim csvLastRow As Long
Dim materialWorkbook As Workbook
Dim materialSheet As Worksheet
Dim materialRange As Range
Dim materialCell As Range
Dim materialLastRow As Long
Dim leadtime As Double
Dim price As Double
Application.ScreenUpdating = False
' Adjust workbook and worksheet names
Set csvWorkbook = Workbooks("Job MMRF.csv")
Set csvSheet = csvWorkbook.Worksheets("CSV SHEET NAME") ' <- ADJUST SHEET NAME
Set materialWorkbook = Workbooks("U100 Material Information.xlsx")
Set materialSheet = materialWorkbook.Worksheets("MATERIAL SHEET NAME") ' <- ADJUST SHEET NAME
' This looks for the last row in column C
csvLastRow = csvSheet.Cells(csvSheet.Rows.Count, "C").End(xlUp).Row
' This looks for the last row in column A
materialLastRow = materialSheet.Cells(materialSheet.Rows.Count, "A").End(xlUp).Row
' Set the range from C1 to last row
Set csvRange = csvSheet.Range("C1:C" & csvLastRow)
Set materialRange = materialSheet.Range("A1:A" & materialLastRow)
' Loop through each cell in target range
For Each csvcell In csvRange.Cells
' If no value
Select Case True
Case Trim(csvcell.Value) = vbNullString
csvcell.Offset(, -2).Font.Color = vbRed
csvcell.Offset(, 9).Value = "Need to contact vendor"
csvcell.Offset(, 10).Value = "Need to contact vendor"
' Reset if null?
price = 0
leadtime = 0
Case Else
' Get matching cell in material workbook
Set materialCell = GetMatchedCell(materialRange, csvcell.Value)
' If found
If Not materialCell Is Nothing Then
price = materialCell.Offset(, 15).Value
leadtime = materialCell.Offset(, 13).Value
Else
' Reset if not?
price = 0
leadtime = 0
End If
' Moved this to only the cases where the csvcell value is different than null
With csvcell
If price = 0.01 And leadtime = 21 Then
.Offset(, -2).Font.ColorIndex = 7
.Offset(, 9).Value = leadtime
.Offset(, 10).Value = price
Else
.Offset(, -2).Font.Color = vbGreen
.Offset(, 9).Value = leadtime
.Offset(, 10).Value = price
End If
End With
End Select
Next csvcell
Application.ScreenUpdating = True
End Sub
Private Function GetMatchedCell(ByVal lookupRange As Range, ByVal lookupValue As Variant) As Range
Dim lookupCell As Range
For Each lookupCell In lookupRange.Cells
If lookupCell.Value = lookupValue Then
Set GetMatchedCell = lookupCell
Exit For
End If
Next lookupCell
End Function
Let me know if it works