Read Array of Files and Read Them One By One Nodejs - node.js

Question

I would like to start by saying that I am relatively new to JS and so I welcome any helpful suggestions.
Here's what it should do:
Reads directory files
Loops through the array of files
SHOULD: Read file & upload it to the s3
What it does:
Reads directory files ✅
Loops through the array of files ✅
Never passes this:
Files size are: 1 to 2 mb, 12 files length or 6 either way it does not work.
if (content.length < 1) return console.log("Content < 1")
code:
async s3() {
AWS.config.update({
accessKeyId: process.env.AWS_ACCESS_KEY_ID,
secretAccessKey: process.env.AWS_SECRET_KEY,
})
const s3 = new AWS.S3()
const destination = path.join(Utils.getRootPath(), 'uploads', this.email)
try {
const files = fs.readdirSync(destination)
if (!files || files.length == 0) return console.log(`Provided folder '${destination}' is empty or does not exist.`);
for (const fileName of files) {
const filePath = path.join(destination, fileName)
let content = fs.readFileSync(filePath)
if (content.length < 1) return console.log("Content < 1")
s3.upload({
ACL: 'public-read',
Bucket: process.env.AWS_BUCKET_NAME,
Key: fileName,
Body: fileContent,
}).promise().then(async (uploadData) => {
try {
const headData = await s3.headObject({
Bucket: process.env.AWS_BUCKET_NAME,
Key: fileName,
}).promise();
return console.log(headData);
}
catch (err) {
console.log(err);
}
})
console.log(`${fileName} uploaded.`)
}
} catch (error) {
throw new Error(error)
}
Caller:
async container() {
if (this.email === null) throw new Error('Constructor of Job class is null')
try {
await this.placeOrder();
await Utils.downloadFile(this.email);
await this.s3();
return console.log("DONE!")
}
catch (err) {
// return new Error(err);
// OBRADA OVDE!
console.log(err)
}
}

Answer 1

There are a couple issues, assuming I understand this correctly. First, instead of returning from the for-of loop when content.length < 1, you should just continue. Otherwise you won't continue to process the remaining files. Second, it's generally not a good idea to mix promises and async/await. You can use await on s3.upload.
class FileManager {
async s3() {
console.log('ok')
AWS.config.update({
accessKeyId: process.env.AWS_ACCESS_KEY_ID,
secretAccessKey: process.env.AWS_SECRET_KEY,
});
const s3 = new AWS.S3();
const destination = path.join(Utils.getRootPath(), "uploads", this.email);
try {
const files = fs.readdirSync(destination);
if (!files || files.length == 0)
return console.log(`Provided folder '${destination}' is empty or does not exist.`);
for (const fileName of files) {
const filePath = path.join(destination, fileName);
let content = fs.readFileSync(filePath);
if (content.length < 1) {
console.log("Content < 1");
continue;
}
await s3.upload({
ACL: "public-read",
Bucket: process.env.AWS_BUCKET_NAME,
Key: fileName,
Body: fileContent,
});
try {
const headData = await s3
.headObject({
Bucket: process.env.AWS_BUCKET_NAME,
Key: fileName,
})
.promise();
console.log(headData);
} catch (err) {
console.log(err);
}
console.log(`${fileName} uploaded.`);
}
} catch (error) {
throw new Error(error);
}
}
}