Hi I am pushed by deadlines, so I will post my question here as I go along with my search..here is my script, all it does is look at every file of a folder, and create different "list.txt" depending of the value of "tree_size.txt" formated as CSV.txt (filename,size):
FOR %%I in (%inputDir%\*.*) DO (
FOR /F "tokens=1,2" %%A IN (%tree_size%) DO (
IF %%~nxI==%%A IF %%B LEQ 10.000 (
echo %%~dpnxI >> %inputDir%\0_10.txt)
IF %%~nxI==%%A IF %%B GTR 10.000 IF %%B LEQ 25.000 (
echo %%~dpnxI >> %inputDir%\11_25.txt)
IF %%~nxI==%%A IF %%B GTR 25.000 IF %%B LEQ 40.000 (
echo %%~dpnxI >> %inputDir%\26_40.txt)
IF %%~nxI==%%A IF %%B GTR 40.000 IF %%B LEQ 55.000 (
echo %%~dpnxI >> %inputDir%\41_55.txt)
IF %%~nxI==%%A IF %%B GTR 55.000 (
echo %%~dpnxI >> %inputDir%\56_plus.txt)
)
)
My aim is to modify this code in order to use multithread processing, which seams to be an option using batch scripting on Windows 7.
Your problem is one of approach.
As you have 50,000 files and assuming you have 50,000 lines in your tree_size file (of which you've not given us a sample) then you are reading tree_size 50,000 times and executing the if tree 50,000 * 50,000 = 2,500,000,000 times. Each of your comparison blocks makes 5 tests each time = 12,500,000,000 tests.
Try this:
FOR /F "tokens=1,2" %%A IN (%tree_size%) DO if exist "%inputDir%\%%A" (
IF %%B LEQ 10.000 (
echo %inputDir%\%%A >> %inputDir%\0_10.txt
) else (
IF %%B LEQ 25.000 (
echo %inputDir%\%%A >> %inputDir%\11_25.txt
) else (
IF %%B LEQ 40.000 (
echo %inputDir%\%%A >> %inputDir%\26_40.txt
) else (
IF %%B LEQ 55.000 (
echo %inputDir%\%%A >> %inputDir%\41_55.txt
) else (
echo %inputDir%\%%A >> %inputDir%\56_plus.txt
)))))
)
which should accomplish the same thing using only 50,000 cycles of the inner loop.
Related
The code is like this but it doesn't work as expected right now:
#ECHO OFF
for /f %%i in ('dir *.mov /b') do call :test %%i
goto continue
:test
if "%1"=="*compressed.mov" goto :eof
echo "%~f1"
goto :eof
:continue
pause
I would like to solve two problems here:
How to escape spaces in file names? ie. I would like to include "video 1.mov" file for the test and not echo just the "Drive:\path\video" but instead "Drive:\path\video 1.mov"
How to not echo any file containing string "compressed" at the end of it's name?
Perhaps something like this would suit:
#Echo Off
SetLocal EnableExtensions DisableDelayedExpansion
For %%G In ("*.mov") Do If /I "%%~xG" == ".mov" (Set "_=%%~nG"
SetLocal EnableDelayedExpansion
If /I Not "!_:~-10!" == "compressed" (EndLocal & Echo "%%~fG"
) Else EndLocal
)
Pause
Alternatively use findstr.exe:
#For /F "EOL=? Delims=" %%G In ('Dir "*.mov" /A:-D /B 2^>NUL ^| %SystemRoot%\System32\findstr.exe /LIE ".mov" ^| %SystemRoot%\System32\findstr.exe /VLIE "compressed.mov"') Do #Echo "%__CD__%%%G"
#Pause
I have a directory full of files that look like the following:
Codian1_OCT_14_2014_14_52_ccc145b1_WMV.asf
Codian1_OCT_14_2014_14_52_ccc145b1_ASF.asf
Codian1_OCT_13_2014_12_52_ccc145b1_WMV.asf
Codian1_OCT_13_2014_12_52_ccc145b1_ASF.asf
I'm trying to test if the file ends in either WMV.asf or ASF.asf. For some reason the following code doesn't work:
FOR %%i IN (*) DO (IF %%~i=="*WMV.asf" (echo %%~i IS wmv.asf) ELSE (echo %%~i isn't wmv.asf))
Any idea how to do this?
All comparisons should be case insensitive, since Windows doesn't care about case within file paths.
Option 1
#echo off
setlocal enableDelayedExpansion
for %%i in (*) do (
set "file=%%i"
if /i "!file:~-7!"=="wmv.asf" (echo %%i IS wmv.asf) else (echo %%i isn't wmv.asdf)
)
Option 2
for %%i in (*) do echo %%i|findstr /ile "wmv.asf" >nul && (echo %%i IS wmv.asf) || (echo %%i isn't wmv.asf)
A way :
#echo off
setlocal enabledelayedexpansion
FOR %%i IN (*) DO (
set $File=%%i
if /i !$File:~-7!==WMV.asf echo !$File! -^> WMV
if /i !$File:~-7!==ASF.asf echo !$File! -^> ASF)
I want to trim a text file from both top and bottom.
Say if the text file contain 90 lines. I want to delete top x lines and bottom y lines and update the file. (ie leave only the range x+1 to y-1.
Hence I to intend write a batch file and run it as follow.
trimmer.bat file1.txt 2 8
This code below has following limitations
(a) file open/amend twice
(b) Trims blank lines within the range (I do not wish to remove these lines)
Please help me to correct
#echo off
rem %1% file name %2%range begins %3%range ends
rem Step1: this code trims the bottom section
set /a bot_trim=%3
echo Removing...
for /f "skip=%bot_trim% delims=*" %%a in (%1) do (
echo %%a >>newfile.txt
) >nul
echo Lines removed, rebuilding file...
xcopy newfile.txt %1 /y >nul
echo File rebuilt, removing temporary files
del newfile.txt /f /q >nul
echo file bottom trimmed...
rem Step2: this code trims the Top section
set /a Top_trim=%2-1
echo Removing...
for /f "skip=%Top_trim% delims=*" %%a in (%1) do (
echo %%a >>newfile.txt
) >nul
echo Lines removed, rebuilding file...
xcopy newfile.txt %1 /y >nul
echo File rebuilt, removing temporary files
del newfile.txt /f /q >nul
echo file bottom trimmed...
echo file trim completed !!
pause
contents of file1.txt
aa
ff
ff
dd
dd
ee
ee
ee
#ECHO OFF
SETLOCAL
FOR /f "tokens=1-3 delims=:" %%a IN ('FIND /c /v "" %1') DO IF "%%c"=="" (SET /a endline=%%b-%3) ELSE (SET /a endline=%%c-%3)
ECHO %2 %endline%
(
FOR /f "tokens=1*delims=:" %%a IN ('findstr /n /r "^" %1') DO (
IF %%a gtr %endline% GOTO done
IF %%a gtr %2 ECHO(%%b
)
)>newfile.txt
:done
GOTO :EOF
Designed to suit your original specification. No attempt to cater for spaces and batch-significant symbols in file/directorynames, but directorynames may be used if required.
Lines beginning : will be damaged.
Produces newfile.txt
I've got a script to retrieve PowerPath license information from arround 2k servers, I've automated this with simple script:
for /F %%A in (server_list.txt) do (
echo %%A >> PP_license.txt
psexec \\%%A powermt check_registration | find "Key" >> PP_license.txt
)
But I'm not happy with this output file, which now looks like this:
server1
Key XXXX-XXXX
server2
Key YYYY-YYYY
Is it possible to manipulate this to get output like:
server1 XXXX-XXXX
server2 YYYY-YYYY
?
If not then I'll try do this in PowerShell.
for /F %%A in (server_list.txt) do (
for /F "tokens=1*" %%B in ('psexec \\%%A powermt check_registration ^| find "Key" ') do (
echo %%A %%C>> PP_license.txt
)
)
Try this
ren PP_license.txt PP_license.tmp
3<PP_license.tmp (
:loop
set /p srv=<&3
set /p key=<&3
if "%srv%"=="" goto :end
<nul set /p=%srv% >> PP_license.txt
for /f "tokens=2" %%a in "%key%" do set key=%%a
Echo %key% >> PP_license.txt
goto :loop
:end
)
And that should do exactly what you want.
Mona
for /F %%A in (server_list.txt) do (
(echo|set /p"= %%A ")>> PP_license.txt
for /f "tokens=* delims=" %%x in ('psexec \\%%A powermt check_registration ^| find "Key" ') do (
(echo %%x)>>PP_license.txt
)
)
I have created code which loops through each line of files.txt and identifies if the file is car, boat or neither and stores this information into SendType.txt. This is accomplished by using the findstr command and searching through the list of boat.txt and car.txt. Essentially the way the code is designed, it will take the first line of files.txt and see if it can find the string in car.txt (if so car is output to SendType.txt) if not it will search for the string in boat.txt (if the string is found in boat.txt, boat is output to SendType.txt), and if the string is not found in either car.txt or boat.txt, then the text neither is output to SendType.txt
Right now the code searches for the entire string line. Each string is similar to 11111_2222-22_2010-09-09_10-24-20.zip (11111=ID, 2222-22=model, 2010-09-09=date, 10-24-20=transaction ID).
I would like to replace my current findstr line, which searches the entire line, to search for the entire string EXCEPT the date portion. I have attached my code below for reference along with some examples of the files being input. Thanks in advance!
#echo off
FOR /F %%a in (files.txt) do (
findstr %%a car.txt
if errorlevel 1 (
findstr %%a boat.txt
if errorlevel 1 (
echo neither >>SendType.txt
) else (
echo boat >>SendType.txt
)
) else (
echo car >>SendType.txt
)
)
car.txt
11111_2222-22_2010-09-09_10-24-20.zip
11112_2222-11_2011-11-09_10-24-25.zip
boat.txt
11122_1111-22_2012-04-09_11-29-56.zip
11144_3333-11_2011-12-22_06-29-66.zip
files.txt
11122_1111-22_2000-01-01_11-29-56.zip
11144_3333-11_2000-01-01_06-29-66.zip
11155_1212-12_2000-01-01_11-19-69.zip
11111_2222-22_2000-01-01_10-24-20.zip
11112_2222-11_2000-01-01_10-24-25.zip
12345_2233-12_2000-01-01_07-27-44.zip
DESIRED OUTPUT:
SendType.txt
boat
boat
neither
car
car
neither
UPDATE 10/15 3:00 PM
The current approach using dbenham's code and the parsing technique is as follows:
#echo off
>SendType.txt (
for /f "tokens=1,2,3,4 delims=_" %%a in (filenames.txt) do (
findstr /c:"%%a_%%b_%%d" sneakernet.txt >nul && (echo sneakernet) || (
findstr /c:"%%a_%%b_%%d" devmed.txt >nul && (echo devmed) || echo tanto
)
)
)
If the format of the IDs is fixed with two _ that precede the date, then the solution is easy: simply use FOR /F to parse the values.
I like to use && and || instead of testing ERRORLEVEL. Also, you don't need the output of FINDSTR, so you can redirect to nul. You should verify that the string matches from the begining of the line. Finally, you only need to redirect once, so you can overwrite instead of append - easier to test repeatedly because no need to delete before start.
#echo off
>SendType.txt (
for /f "tokens=1,2 delims=_" %%a in (files.txt) do (
findstr /bc:"%%a_%%b" car.txt >nul && (echo car) || (
findstr /bc:"%%a_%%b" boat.txt >nul && (echo boat) || echo neither
)
)
)
If the format (and possibly length) of the ID can vary, but the format (length) of the date portion is constant, then you can use a substring:
#echo off
setlocal enableDelayedExpansion
>SendType.txt (
for /f "delims=" %%a in (files.txt) do (
set "ln=%%a"
findstr /bc:"!ln:~0,-23!" car.txt >nul && (echo car) || (
findstr /bc:"!ln:~0,-23!" boat.txt >nul && (echo boat) || echo neither
)
)
)
If neither the ID nor date format is constant, then I would change the content of boat.txt and car.txt by stripping off the date portion. Then you can use the FINDSTR /G option. The /I option is needed because of a bug in FINDSTR.
car.txt
11111_2222-22
11112_2222-11
boat.txt
11122_1111-22
11144_3333-11
#echo off
setlocal enableDelayedExpansion
>SendType.txt (
for /f "delims=" %%a in (files.txt) do (
echo %%a|findstr /blig:car.txt >nul && (echo car) || (
echo %%a|findstr /blig:boat.txt >nul && (echo boat) || echo neither
)
)
)
Updated answer
Now that I understand the requirements, this should solve the problem. I've basically used a variation of the 1st code in my original answer, and I've switched to using a regular expression. The test could be made more stringent by substituting [0-9] for each . in the regex.
#echo off
>SendType.txt (
for /f "tokens=1,2,4 delims=_" %%a in (files.txt) do (
findstr /brc:"%%a_%%b_....-..-.._%%c" car.txt >nul && (echo car) || (
findstr /brc:"%%a_%%b_....-..-.._%%c" boat.txt >nul && (echo boat) || echo neither
)
)
)