speed up in DC's scanning - multithreading

I'm building a script which will go to each DC's and take the value from modifyTimeStampe values and then on take the maximum value as the following code, at the moment the code is too slow because now it goes to each domain and put the value to the array, then get the max value from the array out. I would like to speed it up. I was thinking to use multiple threads, but still looking for a better idea to implement.
$Searcher = New-Object System.DirectoryServices.DirectorySearcher
$Searcher.PageSize = 100
$Searcher.SearchScope = "subtree"
$Searcher.Filter = "(&(objectCategory=$objectCategory)(objectClass=$objectClass))"
$Searcher.PropertiesToLoad.Add("distinguishedName")|Out-Null
$Searcher.PropertiesToLoad.Add("modifyTimeStamp")|Out-Null
Function modiScan{
forEach ($users In $userObjects)
{
$DN = $users.Properties.Item("distinguishedName")[0]
$dnarr.add($DN)|Out-Null
}
#$dnarr
foreach($dnn in $dnarr){
$error = $false
$lastmd = New-Object System.Collections.ArrayList
ForEach ($DC In $Domain.DomainControllers){
$Server = $DC.Name
$Base = "LDAP://$Server/"+$dnn
$Searcher.SearchRoot = $Base
try{
$Results2 = $Searcher.FindAll()
ForEach ($Result2 In $Results2)
{
$DN2 = $Result2.Properties.Item("distinguishedName")[0]
if($DN2 -eq $dnn){
$modi = $Result2.Properties.Item("modifyTimeStamp")[0]
if($modi){
$lastmd.Add($modi)|Out-Null
}
}
}
}
catch{
$error = $true
}
}
if($error -eq $true){
$lastModi = "None-set"
$global:noneModi++
}
else{
$lastModi = ($lastmd |measure -max).maximum
if($lastModi -ne $null){
$lastModi = $lastModi.ToString("yyyy/MM/dd")
if($lastModi.split("/")[0] -eq 2015){
$global:modi2015++
}
elseif($lastModi.split("/")[0] -eq 2016){
$global:modi2016++
}
elseif($lastModi.split("/")[0] -eq 2017){
$global:modi2017++
}
else{
$global:otherModi++
}
}
else{
$lastModi = "N/A"
$global:noneModi++
}
}
#$lastModi
$obj = New-Object -TypeName psobject
$obj | Add-Member -MemberType NoteProperty -Name "modi" -Value $lastModi
$obj | Export-Csv -Path "$outFileModi" -NoTypeInformation -append -Delimiter $Delimiter
}
}
modiScan

Related

Powershell script and Excel

I had coded a powershell executable in a evaluation windows server, where it worked fine. That is because it had Office (Excel) installed, hence it was possible to run $ExcelObj = New-Object -comobject Excel.Application. However, when moving on to the production server, my systems admin stressed that Office installation is strictly prohibited in the production server, making it not possible to execute the above command, and hence the remaining commands. I am not sure how to continue/change my code from this point onwards. I did search up and found this. But Its structure and method of writing to excel file is too "example", and am not able to figure out how to modify it to my preference. I really need this to work out.
Script.ps1:
#Exception for error hiding during debug
$ErrorActionPreference = 'SilentlyContinue'
#Variables
$PathFileCSV = "C:\Users\Administrator\Desktop\FinalPrototype.csv" #for actual
$PathFileXLSX = "C:\Users\Administrator\Desktop\FinalPrototype.xlsx" #for actual
#Function for file deletion (xlsx)
if ((Test-Path $PathFileXLSX)) {
Remove-Item $PathFileXLSX -Force
}
#Code to stop any running instance of excel, to prevent additional files from being created
# Stop-Process -processname excel -Force
#Function from Github (src:https://github.com/gangstanthony/PowerShell)
function Save-CSVasExcel {
param (
[string]$CSVFile = $(Throw 'No file provided.')
)
BEGIN {
function Resolve-FullPath ([string]$Path) {
if ( -not ([System.IO.Path]::IsPathRooted($Path)) ) {
# $Path = Join-Path (Get-Location) $Path
$Path = "$PWD\$Path"
}
[IO.Path]::GetFullPath($Path)
}
function Release-Ref ($ref) {
([System.Runtime.InteropServices.Marshal]::ReleaseComObject([System.__ComObject]$ref) -gt 0)
[System.GC]::Collect()
[System.GC]::WaitForPendingFinalizers()
}
$CSVFile = Resolve-FullPath $CSVFile
$xl = New-Object -ComObject Excel.Application
}
PROCESS {
$wb = $xl.workbooks.open($CSVFile)
$xlOut = $CSVFile -replace '\.csv$', '.xlsx'
# can comment out this part if you don't care to have the columns autosized
# $ws = $wb.Worksheets.Item(1)
# $range = $ws.UsedRange
# [void]$range.EntireColumn.Autofit()
$num = 1
$dir = Split-Path $xlOut
$base = $(Split-Path $xlOut -Leaf) -replace '\.xlsx$'
$nextname = $xlOut
while (Test-Path $nextname) {
$nextname = Join-Path $dir $($base + "-$num" + '.xlsx')
$num++
}
$wb.SaveAs($nextname, 51)
}
END {
$xl.Quit()
$null = $ws, $wb, $xl | ForEach-Object { Release-Ref $_ }
del $CSVFile
}
}
#Function to create the CSV File
Get-ADUser -Filter * -Properties * -SearchBase "DC=devops,DC=company1" | select-object displayName, mail, #{n = 'OU'; e = { (($_.DistinguishedName -replace '^.*?,(?=[A-Z]{2}=)' -split ',')[0]).substring(3) } } | Export-CSV -Path $PathFileCSV -NoTypeInformation
#select-object #{name = "MemberOf"; expression = { ($_.memberof | ForEach-Object { (Get-ADObject $_).Name }) -join " | " } } --- for user roles
#select-object sAMAccountName --- for username
#Function to convert created CSV to XLS (With formatted column)
Save-CSVasExcel $PathFileCSV
#Function for file deletion (csv)
#if ((Test-Path $PathFileCSV)) {
# Remove-Item $PathFileCSV -Force
#}
#Beautification
$ExcelObj = New-Object -comobject Excel.Application
$ExcelWorkBook = $ExcelObj.Workbooks.Open($PathFileXLSX)
$ExcelWorkSheet = $ExcelWorkBook.Sheets.Item("FinalPrototype")
#$ExcelWorkSheet.Cells.Font.Name = "Comfortaa"
$ExcelWorkSheet.Cells.Font.Size = 11
#Function for finding user groups & more
$usersAMAccName = Get-ADUser -Filter * -Properties * -SearchBase "DC=devops,DC=company1" | select-object sAMAccountName
$hash.Clear()
$data = #('Name', 'Email', 'Organizational Unit')
$data += #(Get-ADGroup -filter * -searchbase "OU=DevOps User Groups,OU=C1,DC=devops,DC=company1" | Select-Object -expandproperty name )
foreach ($name in $usersAMAccName) {
$hash += [ordered]#{ $name.sAMAccountName = (Get-ADPrincipalGroupMembership $name.sAMAccountName | select-object name).name }
}
#Header-Row-only Beautification
$Rows = $data.Count
for ($i = 1; $i -le $Rows; $i++) {
$ExcelWorkSheet.Cells.Item(1, $i).Font.Size = 16
$ExcelWorkSheet.Cells.Item(1, $i) = $data[$i - 1]
$ExcelWorkSheet.Cells.Item(1, $i).EntireRow.Interior.ColorIndex = 6
}
#Insertion profile-related data
$range = $ExcelWorkSheet.UsedRange
$rangeROW = $ExcelWorkSheet.UsedRange.Rows.Count
$rangeCOL = $ExcelWorkSheet.UsedRange.Columns.Count
for ($i = 2; $i -le $rangeROW; $i++) {
for ($j = 4; $j -le $rangeCOL; $j++) {
if ($hash.($usersAMAccName[$i - 2] | select-object -expandproperty sAMAccountName) -contains $ExcelWorkSheet.Cells.Item(1, $j).value2()) {
$ExcelWorkSheet.Cells.Item($i, $j).Interior.ColorIndex = 4
$ExcelWorkSheet.Cells.Item($i, $j) = "Assigned"
}
else {
$ExcelWorkSheet.Cells.Item($i, $j).Interior.ColorIndex = 3
$ExcelWorkSheet.Cells.Item($i, $j) = "Not Assigned"
}
}
}
#Content-usedRange-only Beautification
$range.EntireColumn.Autofit()
#Non-Human user omission
for ($i = 1; $i -le $rangeROW; $i++) {
If ([string]::IsNullOrEmpty($ExcelWorkSheet.Cells.Item($i, 1).value2)) {
$ExcelWorkSheet.Cells.Item($i, 1).EntireRow.hidden = $true
}
}
#Beautification
$range.WrapText = "True"
$range.HorizontalAlignment = -4108
#Saving the final form of excel
$ExcelObj.DisplayAlerts = $FALSE
$ExcelWorkBook.Save()
$ExcelWorkBook.close($true)
#User Ref (Debug)
Clear-Host
Write-Host 'Debug: Reading' $PathFileXLSX 'now...'
$data = Import-Excel $PathFileXLSX
$data
Final .xlsx file when ran in evaluation server (with excel):

How to Use Multithreading script

I found this Multithreading script at http://www.get-blog.com/?p=189
Param($Command = $(Read-Host "Enter the script file"),
[Parameter(ValueFromPipeline=$true,ValueFromPipelineByPropertyName=$true)]$ObjectList,
$InputParam = $Null,
$MaxThreads = 20,
$SleepTimer = 200,
$MaxResultTime = 120,
[HashTable]$AddParam = #{},
[Array]$AddSwitch = #()
)
Begin{
$ISS = [system.management.automation.runspaces.initialsessionstate]::CreateDefault()
$RunspacePool = [runspacefactory]::CreateRunspacePool(1, $MaxThreads, $ISS, $Host)
$RunspacePool.Open()
If ($(Get-Command | Select-Object Name) -match $Command){
$Code = $Null
}Else{
$OFS = "`r`n"
$Code = [ScriptBlock]::Create($(Get-Content $Command))
Remove-Variable OFS
}
$Jobs = #()
}
Process{
Write-Progress -Activity "Preloading threads" -Status "Starting Job $($jobs.count)"
ForEach ($Object in $ObjectList){
If ($Code -eq $Null){
$PowershellThread = [powershell]::Create().AddCommand($Command)
}Else{
$PowershellThread = [powershell]::Create().AddScript($Code)
}
If ($InputParam -ne $Null){
$PowershellThread.AddParameter($InputParam, $Object.ToString()) | out-null
}Else{
$PowershellThread.AddArgument($Object.ToString()) | out-null
}
ForEach($Key in $AddParam.Keys){
$PowershellThread.AddParameter($Key, $AddParam.$key) | out-null
}
ForEach($Switch in $AddSwitch){
$Switch
$PowershellThread.AddParameter($Switch) | out-null
}
$PowershellThread.RunspacePool = $RunspacePool
$Handle = $PowershellThread.BeginInvoke()
$Job = "" | Select-Object Handle, Thread, object
$Job.Handle = $Handle
$Job.Thread = $PowershellThread
$Job.Object = $Object.ToString()
$Jobs += $Job
}
}
End{
$ResultTimer = Get-Date
While (#($Jobs | Where-Object {$_.Handle -ne $Null}).count -gt 0) {
$Remaining = "$($($Jobs | Where-Object {$_.Handle.IsCompleted -eq $False}).object)"
If ($Remaining.Length -gt 60){
$Remaining = $Remaining.Substring(0,60) + "..."
}
Write-Progress `
-Activity "Waiting for Jobs - $($MaxThreads - $($RunspacePool.GetAvailableRunspaces())) of $MaxThreads threads running" `
-PercentComplete (($Jobs.count - $($($Jobs | Where-Object {$_.Handle.IsCompleted -eq $False}).count)) / $Jobs.Count * 100) `
-Status "$(#($($Jobs | Where-Object {$_.Handle.IsCompleted -eq $False})).count) remaining - $remaining"
ForEach ($Job in $($Jobs | Where-Object {$_.Handle.IsCompleted -eq $True})){
$Job.Thread.EndInvoke($Job.Handle)
$Job.Thread.Dispose()
$Job.Thread = $Null
$Job.Handle = $Null
$ResultTimer = Get-Date
}
If (($(Get-Date) - $ResultTimer).totalseconds -gt $MaxResultTime){
Write-Error "Child script appears to be frozen, try increasing MaxResultTime"
Exit
}
Start-Sleep -Milliseconds $SleepTimer
}
$RunspacePool.Close() | Out-Null
$RunspacePool.Dispose() | Out-Null
}
I'm confused as how to use it though. In particular how to use the $ObjectList variable. I would like to use this ping script that I wrote to ping a list of 100,000 machines... But in it's current form it pings about 100 machines a minute. So it would take over 16 hours to complete.
$Computers = Get-Content -Path C:\Temp\Comps.txt
foreach ($Computer in $Computers) {
if (test-Connection -ComputerName $Computer -Count 1) {
"$Computer is Pinging"
}
Else {
"$Computer is not Pinging"
}
}
Any pointers as to how to integrate the ping script with the multithreading script to yield faster results?
I'm assuming that I would remove the $Computers variable from the ping script, and instead use the $ObjectList variable in the multithreading script. But all of my attempts to do so fail.
You can ping hosts asynchronously with [System.Net.NetworkInformation.Ping], no need to go crazy with runspaces. Moreover it will ping the host once, so it will be way much faster than test-connection. Below is a sample for a batch of hosts (about 90). I guess it's not a good idea to load 100K at once, probably split it in smaller batches and do one by one.
$hosts = "www.facebook.com,www.twitter.com,www.youtu.be,www.google.com,www.youtube.com,www.instagram.com,www.linkedin.com,www.pinterest.com,www.wordpress.com,www.blogspot.com,www.apple.com,www.adobe.com,www.tumblr.com,www.amazon.com,www.vimeo.com,www.flickr.com,www.microsoft.com,www.yahoo.com,www.godaddy.com,www.qq.com,www.vk.com,www.reddit.com,www.baidu.com,www.nytimes.com,www.buydomains.com,www.wp.com,www.statcounter.com,www.jimdo.com,www.blogger.com,www.github.com,www.weebly.com,www.soundcloud.com,www.myspace.com,www.addthis.com,www.theguardian.com,www.cnn.com,www.stumbleupon.com,www.gravatar.com,www.digg.com,www.addtoany.com,www.creativecommons.org,www.paypal.com,www.yelp.com,www.imdb.com,www.huffingtonpost.com,www.feedburner.com,www.issuu.com,www.wixsite.com,www.wix.com,www.dropbox.com,www.forbes.com,www.amazonaws.com,www.washingtonpost.com,www.bluehost.com,www.etsy.com,www.go.com,www.msn.com,www.wsj.com,www.weibo.com,www.fc2.com,www.eventbrite.com,www.parallels.com,www.ebay.com,www.livejournal.com,www.reuters.com,www.taobao.com,www.typepad.com,www.bloomberg.com,www.elegantthemes.com,www.eepurl.com,www.usatoday.com,www.about.com,www.medium.com,www.macromedia.com,www.xing.com,www.bing.com,www.time.com,www.tripadvisor.com,www.aol.com,www.constantcontact.com,www.latimes.com,www.list-manage.com,www.webs.com,www.opera.com,www.live.com,www.bandcamp.com,www.bbc.com,www.businessinsider.com,www.dailymotion.com,www.cpanel.com,www.disqus.com,www.sina.com.cn,www.spotify.com,www.wired.com,www.googleusercontent.com"
$hosts = $hosts -split ","
$tasks = #{}
foreach ($h in $hosts) { $tasks[$h] = [System.Net.NetworkInformation.Ping]::new().SendPingAsync($h)}
Write-Host "Waiting for batch is completed" -NoNewline
while($false -in $tasks.Values.IsCompleted) {sleep -Milliseconds 300; Write-Host "." -NoNewline}
$result = foreach($h in $hosts) {
$r = $tasks[$h].Result
[PSCustomObject]#{
host = $h
address = $r.Address.IPAddressToString
status = if($r.Address.IPAddressToString){$r.Status}else{"Failed"}
time = $r.RoundtripTime
bytes = $r.Buffer.Count
ttl = $r.Options.Ttl
}
}
$result | Format-Table -AutoSize
This script, which I have adapted from the link and author in the synopsis, has good performance for me. I have modified it to take not only a range of ip addresses, but also an array of host names. Because of that, some of the variable names have poor names, but this is not production code so I have not invested in it beyond what I have below.
function Global:Ping-IPRange {
<#
.SYNOPSIS
Sends ICMP echo request packets to a range of IPv4 addresses between two given addresses.
.DESCRIPTION
This function lets you sends ICMP echo request packets ("pings") to
a range of IPv4 addresses using an asynchronous method.
Therefore this technique is very fast but comes with a warning.
Ping sweeping a large subnet or network with many swithes may result in
a peak of broadcast traffic.
Use the -Interval parameter to adjust the time between each ping request.
For example, an interval of 60 milliseconds is suitable for wireless networks.
The RawOutput parameter switches the output to an unformated
[System.Net.NetworkInformation.PingReply[]].
.INPUTS
None
You cannot pipe input to this funcion.
.OUTPUTS
The function only returns output from successful pings.
Type: System.Net.NetworkInformation.PingReply
The RawOutput parameter switches the output to an unformated
[System.Net.NetworkInformation.PingReply[]].
.NOTES
Author : G.A.F.F. Jakobs
Created : August 30, 2014
Version : 6
.EXAMPLE
Ping-IPRange -StartAddress 192.168.1.1 -EndAddress 192.168.1.254 -Interval 20
IPAddress Bytes Ttl ResponseTime
--------- ----- --- ------------
192.168.1.41 32 64 371
192.168.1.57 32 128 0
192.168.1.64 32 128 1
192.168.1.63 32 64 88
192.168.1.254 32 64 0
In this example all the ip addresses between 192.168.1.1 and 192.168.1.254 are pinged using
a 20 millisecond interval between each request.
All the addresses that reply the ping request are listed.
.EXAMPLE
Ping-IPRange -HostName "host1"
Ping-IPRange -HostName #('host1', 'host2')
Ping-IPRange -HostName #('www.microsoft.com', 'www.google.com')
.LINK
http://gallery.technet.microsoft.com/Fast-asynchronous-ping-IP-d0a5cf0e
#>
[CmdletBinding(ConfirmImpact='Low')]
Param(
[parameter(Mandatory = $true, Position = 0, ParameterSetName='range')]
[System.Net.IPAddress]$StartAddress,
[parameter(Mandatory = $true, Position = 1, ParameterSetName='range')]
[System.Net.IPAddress]$EndAddress,
[parameter(Mandatory = $true, Position = 0, ParameterSetName='list')]
[string[]]$HostName,
[int]$Interval = 30,
[Switch]$RawOutput = $false
)
$timeout = 2000
function New-Range ($start, $end) {
$addrList = [System.Collections.ArrayList]::new()
[byte[]]$BySt = $start.GetAddressBytes()
[Array]::Reverse($BySt)
[byte[]]$ByEn = $end.GetAddressBytes()
[Array]::Reverse($ByEn)
$i1 = [System.BitConverter]::ToUInt32($BySt,0)
$i2 = [System.BitConverter]::ToUInt32($ByEn,0)
for($x = $i1;$x -le $i2;$x++){
$ip = ([System.Net.IPAddress]$x).GetAddressBytes()
[Array]::Reverse($ip)
$null = $addrList.Add([System.Net.IPAddress]::Parse($($ip -join '.')))
}
,$addrList
}
if ($HostName)
{
$IPrange = #($HostName)
}
else
{
[System.Collections.ArrayList]$IPrange = New-Range $StartAddress $EndAddress
}
$IpTotal = $IPrange.Count
Get-Event -SourceIdentifier "ID-Ping*" | Remove-Event
Get-EventSubscriber -SourceIdentifier "ID-Ping*" | Unregister-Event
$index = 0
foreach ($ip in $IPrange){
if ($HostName)
{
[string]$VarName = "Ping_" + $ip + "_" + [guid]::NewGuid().ToString()
}
else
{
[string]$VarName = "Ping_" + $ip.Address
}
New-Variable -Name $VarName -Value (New-Object System.Net.NetworkInformation.Ping)
Register-ObjectEvent -InputObject (Get-Variable $VarName -ValueOnly) -EventName PingCompleted -SourceIdentifier "ID-$VarName"
(Get-Variable $VarName -ValueOnly).SendAsync($ip,$timeout,$VarName)
try{
$pending = (Get-Event -SourceIdentifier "ID-Ping*").Count
}catch [System.InvalidOperationException]{
Write-Verbose "Ping-IPrange : InvalidOperationException" -Verbose
}
finally{
Remove-Variable $VarName
}
#$index = [array]::indexof($IPrange,$ip)
if ($HostName)
{
Write-Progress -Activity "Sending ping to" -Id 1 -status $ip -PercentComplete (($index / $IpTotal) * 100)
}
else
{
Write-Progress -Activity "Sending ping to" -Id 1 -status $ip.IPAddressToString -PercentComplete (($index / $IpTotal) * 100)
}
Write-Progress -Activity "ICMP requests pending" -Id 2 -ParentId 1 -Status ($index - $pending) -PercentComplete (($index - $pending)/$IpTotal * 100)
Start-Sleep -Milliseconds $Interval
$index++
}
Write-Progress -Activity "Done sending ping requests" -Id 1 -Status 'Waiting' -PercentComplete 100
While($pending -lt $IpTotal){
Wait-Event -SourceIdentifier "ID-Ping*" | Out-Null
Start-Sleep -Milliseconds 10
$pending = (Get-Event -SourceIdentifier "ID-Ping*").Count
Write-Progress -Activity "ICMP requests pending" -Id 2 -ParentId 1 -Status ($IpTotal - $pending) -PercentComplete (($IpTotal - $pending)/$IpTotal * 100)
}
if($RawOutput){
$Reply = Get-Event -SourceIdentifier "ID-Ping*" | ForEach {
If($_.SourceEventArgs.Reply.Status -eq "Success"){
$_.SourceEventArgs.Reply
}
Unregister-Event $_.SourceIdentifier
Remove-Event $_.SourceIdentifier
}
}else{
$events = Get-Event -SourceIdentifier "ID-Ping*"
$Reply = [System.Collections.ArrayList]::new()
$i = 0
foreach ($event in $events) {
If($event.SourceEventArgs.Reply.Status -eq "Success"){
if ($HostName)
{
$null = $Reply.Add(
[PSCustomObject]#{
"HostName" = $HostName[$i]
"IPAddress" = $event.SourceEventArgs.Reply.Address
"Bytes" = $event.SourceEventArgs.Reply.Buffer.Length
"Ttl" = $event.SourceEventArgs.Reply.Options.Ttl
"ResponseTime" = $event.SourceEventArgs.Reply.RoundtripTime
}
)
}
else
{
$null = $Reply.Add(
[PSCustomObject]#{
"IPAddress" = $event.SourceEventArgs.Reply.Address
"Bytes" = $event.SourceEventArgs.Reply.Buffer.Length
"Ttl" = $event.SourceEventArgs.Reply.Options.Ttl
"ResponseTime" = $event.SourceEventArgs.Reply.RoundtripTime
}
)
}
}
else{
$addr = ($event.SourceIdentifier -split '_')[1]
$ip = ((([System.Net.IPAddress]$addr).IPAddressToString).Split('.'))
[Array]::Reverse($ip)
$ip = $ip -join '.'
if ($HostName)
{
$null = $Reply.Add(
[PSCustomObject]#{
"HostName" = $HostName[$i]
"IPAddress" = '0.0.0.0'
"Bytes" = -1
"Ttl" = -1
"ResponseTime" = -1
}
)
}
else
{
$null = $Reply.Add(
[PSCustomObject]#{
"IPAddress" = $ip
"Bytes" = -1
"Ttl" = -1
"ResponseTime" = -1
}
)
}
}
Unregister-Event $event.SourceIdentifier
Remove-Event $event.SourceIdentifier
$i++
}
}
if($Reply -eq $Null){
Write-Verbose "Ping-IPrange : No ip address responded" -Verbose
}
return ,$Reply
}

Can't Make Two Identical QR Code Srtings Equal Each Other

This is my first post on here. I am pretty new to coding and Powershell so I might be missing something obvious here. I made a QR code label maker for my work using Powershell and Smartsheet. Without getting into too much detail on that it pulls data from a line in a "Product Tracker" we made in Smartsheet and creates a label with a QR code from that data. In one of the columns on that line it mimics the data produced when you scan the QR code. It mimics it like this....
$SkuCell.Value = "BEGIN:VCARD
VERSION:3.0
KIND:individual
N:$($ptCO.Desc);$($ptCO.Po)
FN:$($ptCO.Po) $($ptCO.Desc)
ORG:All New Glass
EMAIL;TYPE=INTERNET:$($ptCO.Assign)
END:VCARD"
... and the output looks like this.....
BEGIN:VCARD
VERSION:3.0
KIND:individual
N:Test stuff here;12354
FN:12354 Test stuff here
ORG:All New Glass
EMAIL;TYPE=INTERNET:ericg#allnewglass.com
END:VCARD
Then on a different Smartsheet our drivers will scan the QR code on the label signifying that its leaving our hub. The scanned data in that cell looks like this.....
BEGIN:VCARD
VERSION:3.0
KIND:individual
N:Test stuff here;12354
FN:12354 Test stuff here
ORG:All New Glass
EMAIL;TYPE=INTERNET:ericg#allnewglass.com
END:VCARD
I then have a different script checking for matches between the two sheets so In the product tracker we know when something leaves the hub. The problem is that even though the scanned data and the mimicked data look absolutely identical and they both say they are strings, they never match. They are not equal to each other and I have tried EVERYTHING ([string], out-string, convert-string, compare-object, trim, etc) I can think of to get them to match and the only thing that works is if I pipeline Out-Host on the objects. However, these objects are contained in a foreach loop that checks through all the rows in both sheets which means that the script runs way to slow having to display all that data. It seems likely that there are some hidden characters in the scanned data causing them to not match. Can anyone think of a solution to make these two strings identical? Is there a way of removing all hidden characters? Or does anyone have a better idea? A different way to compare them maybe?
Here's the code that tries to compare....
# by GrEcHkO
#cd "C:\Users\Jacly\Desktop\ANG_System_Files"
cd "P:\ANG_System_Files"
function Load-Dll
{
param(
[string]$assembly
)
Write-Host "Loading $assembly"
$driver = $assembly
$fileStream = ([System.IO.FileInfo] (Get-Item $driver)).OpenRead();
$assemblyBytes = new-object byte[] $fileStream.Length
$fileStream.Read($assemblyBytes, 0, $fileStream.Length) | Out-Null;
$fileStream.Close();
$assemblyLoaded = [System.Reflection.Assembly]::Load($assemblyBytes);
}
function Get-ComparisonObjects
{
param([Smartsheet.Api.Models.Sheet]$sheet)
Write-Host "Getting Sheet $($sheet.Name) Comparison Objects"
$data = $sheet.Rows | foreach {
$checkVal = $false
$trackedCheckVal = $false
$finishedCheckVal = $false
if($_.Cells[3].Value -eq $true)
{
$checkVal = $true
}
if($_.Cells[16].Value -eq $true)
{
$trackedCheckVal = $true
}
if($_.Cells[12].Value -eq $true)
{
$finishedCheckVal = $true
}
[pscustomobject]#{
Attachments = $_.Attachments;
RowId = $_.Id;
RowNumber = $_.RowNumber;
Parent = $_.ParentId;
PoCol = $_.Cells[0].ColumnId;
Po = $_.Cells[0].Value;
JobsCol = $_.Cells[1].ColumnId;
Jobs = $_.Cells[1].Value;
DescCol = $_.Cells[2].ColumnId;
Desc = $_.Cells[2].Value;
CheckCol = $_.Cells[3].ColumnId;
Check = $checkVal;
SupplierCol = $_.Cells[4].ColumnId;
Supplier = $_.Cells[4].Value;
AssignCol = $_.Cells[5].ColumnId;
Assign = $_.Cells[5].Value;
DestinationCol = $_.Cells[11].ColumnId;
Destination = $_.Cells[11].Value;
FinishedCol = $_.Cells[12].ColumnId;
Finished = $finishedCheckVal;
DueCol = $_.Cells[14].ColumnId;
Due = $_.Cells[14].Value;
DeliveryCol = $_.Cells[15].ColumnId;
Delivery = $_.Cells[15].Value;
TrackedCol = $_.Cells[16].ColumnId;
Tracked = $trackedCheckVal;
SKUCol = $_.Cells[18].ColumnId;
SKU = $_.Cells[18].Value;
}
}| where {![string]::IsNullOrWhiteSpace($_.Po)}
Write-Host "$($data.Count) Returned"
return $data
}
function Get-DriverComparisonObjects
{
param([Smartsheet.Api.Models.Sheet]$sheet)
Write-Host "Getting Sheet $($sheet.Name) Comparison Objects"
$data = $sheet.Rows | foreach {
$checkVal = $false
$trackedCheckVal = $false
$finishedCheckVal = $false
$archiveCheckVal = $false
if($_.Cells[2].Value -eq $true)
{
$checkVal = $true
}
if($_.Cells[8].Value -eq $true)
{
$trackedCheckVal = $true
}
if($_.Cells[3].Value -eq $true)
{
$finishedCheckVal = $true
}
if($_.Cells[11].Value -eq $true)
{
$archiveCheckVal = $true
}
[pscustomobject]#{
Attachments = $_.Attachments;
RowId = $_.Id;
RowNumber = $_.RowNumber;
Parent = $_.ParentId;
DayCol = $_.Cells[0].ColumnId;
Day = $_.Cells[0].Value;
DueCol = $_.Cells[1].ColumnId;
Due = $_.Cells[1].Value;
CompletedCol = $_.Cells[2].ColumnId; #########hidden
Completed = $checkVal;
CheckCol = $_.Cells[3].ColumnId;
Check = $finishedCheckVal;
SupplierCol = $_.Cells[4].ColumnId;#########hidden
Supplier = $_.Cells[4].Value;
AssignCol = $_.Cells[5].ColumnId;#########hidden
Assign = $_.Cells[5].Value;
JobNameCol = $_.Cells[6].ColumnId;
JobName = $_.Cells[6].Value;
MainCol = $_.Cells[7].ColumnId;
Main = $_.Cells[7].Value;
TrackedCol = $_.Cells[8].ColumnId;
Tracked = $trackedCheckVal;
PoNumCol = $_.Cells[9].ColumnId;
PoNum = $_.Cells[9].Value;
ModifiedCol = $_.Cells[10].ColumnId;
Modified = $_.Cells[10].Value;
ArchiveCol = $_.Cells[11].ColumnId;
Archive = $archiveCheckVal;
}
} | where {![string]::IsNullOrWhiteSpace($_.PoNum)}
Write-Host "$($data.Count) Returned"
return $data
}
function Get-AttachmentFromSmartsheet
{
param (
[long]$attachmentId,
[long]$sheetId
)
Write-Host "Getting Attachement $attachmentId of Sheet $sheetId"
try
{
$attachment = $client.SheetResources.AttachmentResources.GetAttachment($sheetId,$attachmentId)
}
catch
{
Write-Error $_.Exception.Message
Write-Host ""
}
$downloads = New-Item -ItemType Directory ".\downloads" -Force
$filepath = "$($downloads.Fullname)\$($attachment.Name)"
Write-Host "Downloading $filepath"
Invoke-WebRequest -Uri $attachment.Url -OutFile $filepath
Get-Item $filepath
}
function Save-AttachmentToSheetRow
{
param(
[long]$sheetId,
[long]$rowId,
[System.IO.FileInfo]$file,
[string]$mimeType
)
Write-Host "Saving $($file.Fullname) to Sheet $sheetId"
$result = $client.SheetResources.RowResources.AttachmentResources.AttachFile($sheetId, $rowId, $file.FullName, $mimeType)
return $result
}
function Merge-DriverChecklistWithProductTracker
{
param(
[pscustomobject[]]$orbitalRecords,
[long]$orbitalId
)
foreach ($orbitalRecord in $orbitalRecords)
{
$descFound = $false
$skuFound = $false
if ($orbitalRecord.Archive -eq $false) #THIS IS WHERE I NEED HELP
{ #THIS IS WHERE I NEED HELP
foreach ($ptCO in $ptCOs) #THIS IS WHERE I NEED HELP
{ #THIS IS WHERE I NEED HELP
$orbitalQR = "$($orbitalRecord.PoNum)" #THIS IS WHERE I NEED HELP
$ptQR = "$($ptCO.SKU)" #THIS IS WHERE I NEED HELP
$noParent = $false #THIS IS WHERE I NEED HELP
#THIS IS WHERE I NEED HELP
if ($orbitalQR -eq $ptQR) #THIS IS WHERE I NEED HELP
{ #THIS IS WHERE I NEED HELP
$descFound = $true #THIS IS WHERE I NEED HELP
break #THIS IS WHERE I NEED HELP
} #THIS IS WHERE I NEED HELP
#THIS IS WHERE I NEED HELP
if ($orbitalQR -eq $ptQR) #THIS IS WHERE I NEED HELP
{ #THIS IS WHERE I NEED HELP
$skuFound = $true #THIS IS WHERE I NEED HELP
break #THIS IS WHERE I NEED HELP
} #THIS IS WHERE I NEED HELP
} #THIS IS WHERE I NEED HELP
#THIS IS WHERE I NEED HELP
if ($skuFound) #THIS IS WHERE I NEED HELP
{ #THIS IS WHERE I NEED HELP
if (![string]::IsNullOrWhiteSpace($orbitalRecord.PoNum) -and ![string]::IsNullOrWhiteSpace($ptCO.SKU)) #THIS IS WHERE I NEED HELP
{ #THIS IS WHERE I NEED HELP
Write-Host "SKU found. Updating data on PT." #THIS IS WHERE I NEED HELP
#THIS IS WHERE I NEED HELP
$destinationCell = [Smartsheet.Api.Models.Cell]::new() #THIS IS WHERE I NEED HELP
$destinationCell.ColumnId = $ptDestinationCol.Id #THIS IS WHERE I NEED HELP
$destinationCell.Value = "ITEM SCANNED TO ANG TRUCK" #THIS IS WHERE I NEED HELP
#THIS IS WHERE I NEED HELP
$shippedCell = [Smartsheet.Api.Models.Cell]::new() #THIS IS WHERE I NEED HELP
$shippedCell.ColumnId = $ptShippedCol.Id #THIS IS WHERE I NEED HELP
$shippedCell.Value = if ($orbitalRecord.Modified -ne $null){$orbitalRecord.Modified} else {[string]::Empty} #THIS IS WHERE I NEED HELP
#THIS IS WHERE I NEED HELP
$row = [Smartsheet.Api.Models.Row]::new() #THIS IS WHERE I NEED HELP
$row.Id = $ptCO.RowId #THIS IS WHERE I NEED HELP
$row.Cells = [Smartsheet.Api.Models.Cell[]]#($destinationCell, $shippedCell) #THIS IS WHERE I NEED HELP
#THIS IS WHERE I NEED HELP
$updateRow = $client.SheetResources.RowResources.UpdateRows($ptId, [Smartsheet.Api.Models.Row[]]#($row)) #THIS IS WHERE I NEED HELP
} #THIS IS WHERE I NEED HELP
} #THIS IS WHERE I NEED HELP
elseif ($orbitalRecord.PoNum -eq $ptCO.Po)
{
if ($descFound)
{
if ([string]::IsNullOrWhiteSpace($ptCO.Parent))
{
$noParent = $true
}
if ($noParent)
{
Write-Host "Updating Product Tracker with Driver Checklist $($orbitalRecord.PoNum) $($orbitalRecord.Main)"
$jobsCell = [Smartsheet.Api.Models.Cell]::new()
$jobsCell.ColumnId = $ptJobsCol.Id
$JobsCell.Value = if ($orbitalRecord.JobName -ne $null){$orbitalRecord.JobName} else {[string]::Empty}
$descCell = [Smartsheet.Api.Models.Cell]::new()
$descCell.ColumnId = $ptDescCol.Id
$descCell.Value = if ($orbitalRecord.Main -ne $null){$orbitalRecord.Main} else {[string]::Empty}
$checkCell = [Smartsheet.Api.Models.Cell]::new()
$checkCell.ColumnId = $ptCheckCol.Id
$checkCell.Value = $orbitalRecord.Completed
$assignCell = [Smartsheet.Api.Models.Cell]::new()
$assignCell.COlumnId = $ptAssignCol.Id
$assignCell.Value = if ($orbitalRecord.Assign -ne $null){$orbitalRecord.Assign} else {"ianz#allnewglass.com"}
$supCell = [Smartsheet.Api.Models.Cell]::new()
$supCell.COlumnId = $ptSupplierCol.Id
$supCell.Value = if (($orbitalRecord.Completed -eq $false) -and ($orbitalRecord.Supplier -eq "In Shop FAB")){$suppliers["$fabId"]} else {$suppliers["$DriveId"]}
$finishedCell = [Smartsheet.Api.Models.Cell]::new()
$finishedCell.ColumnId = $ptFinishedCol.Id
$finishedCell.Value = $orbitalRecord.Check
$row = [Smartsheet.Api.Models.Row]::new()
$row.Id = $ptCO.RowId
$row.Cells = [Smartsheet.Api.Models.Cell[]]#($JobsCell, $checkCell, $supCell, $assignCell, $finishedCell)
try
{
$updateRow = $client.SheetResources.RowResources.UpdateRows($ptId, [Smartsheet.Api.Models.Row[]]#($row))
$reference = if ($orbitalRecord.Attachments.Name -ne $null){$orbitalRecord.Attachments.Name} else {[string]::Empty}
$difference = if ($ptCO.Attachments.Name -ne $null){$ptCO.Attachments.Name} else {[string]::Empty}
$compareResults = Compare-Object -ReferenceObject $reference -DifferenceObject $difference -IncludeEqual -SyncWindow ([int]::MaxValue)
$missing = $compareResults | where SideIndicator -eq '<='
$missingAttachments = $missing.InputObject
$attachmentsToGet = $orbitalRecord.Attachments | where Name -in $missingAttachments
foreach($attachment in $attachmentsToGet)
{
Write-Host "Adding missing attachment $($attachment.name)"
$file = Get-AttachmentFromSmartsheet -attachmentId $attachment.Id -sheetId $orbitalId
$result = Save-AttachmentToSheetRow -sheetId $ptId -rowId $newRow.Id -file $file.FullName -mimeType $attachment.MimeType
}
}
catch
{
Write-Error $_.Exception.Message
Write-Host ""
}
if ($orbitalRecord.Check -eq $true)
{
$dateCell = [Smartsheet.Api.Models.Cell]::new()
$dateCell.ColumnId = $ptShippedCol.Id
$dateCell.Value = $orbitalRecord.Modified
$row = [Smartsheet.Api.Models.Row]::new()
$row.Id = $ptCO.RowId
$row.Cells = [Smartsheet.Api.Models.Cell[]]#($dateCell)
try
{
$updateRow = $client.SheetResources.RowResources.UpdateRows($ptId, [Smartsheet.Api.Models.Row[]]#($row))
}
catch
{
Write-Error $_.Exception.Message
Write-Host ""
}
}
if (![string]::IsNullOrWhiteSpace($orbitalRecord.Due))
{
$dateCell = [Smartsheet.Api.Models.Cell]::new()
$dateCell.ColumnId = $ptAnticipatedCol.Id
$dateCell.Value = $orbitalRecord.Due
$row = [Smartsheet.Api.Models.Row]::new()
$row.Id = $ptCO.RowId
$row.Cells = [Smartsheet.Api.Models.Cell[]]#($dateCell)
try
{
$updateRow = $client.SheetResources.RowResources.UpdateRows($ptId, [Smartsheet.Api.Models.Row[]]#($row))
}
catch
{
Write-Error $_.Exception.Message
Write-Host ""
}
}
}
}
}
else
{
if (!($descFound -or $skuFound))
{
if (![string]::IsNullOrWhiteSpace($orbitalRecord.PoNum))
{
if ($orbitalRecord.Tracked -eq "$true")
{
Write-Host "Adding to Product Tracker from Driver Checklist $($orbitalRecord.Po) $($orbitalRecord.Main)"
$poCell = [Smartsheet.Api.Models.Cell]::new()
$poCell.ColumnId = $ptPoCol.Id
$poCell.Value = if ($orbitalRecord.PoNum -ne $null){$orbitalRecord.PoNum} else {[string]::Empty}
$jobsCell = [Smartsheet.Api.Models.Cell]::new()
$jobsCell.ColumnId = $ptJobsCol.Id
$JobsCell.Value = if ($orbitalRecord.JobName -ne $null){$orbitalRecord.JobName} else {[string]::Empty}
$descCell = [Smartsheet.Api.Models.Cell]::new()
$descCell.ColumnId = $ptDescCol.Id
$descCell.Value = if ($orbitalRecord.Main -ne $null){$orbitalRecord.Main} else {[string]::Empty}
$checkCell = [Smartsheet.Api.Models.Cell]::new()
$checkCell.ColumnId = $ptCheckCol.Id
$checkCell.Value = $orbitalRecord.Completed
$supCell = [Smartsheet.Api.Models.Cell]::new()
$supCell.COlumnId = $ptSupplierCol.Id
$supCell.Value = if (($orbitalRecord.Completed -eq $false) -and ($orbitalRecord.Supplier -eq "In Shop FAB")){$suppliers["$fabId"]} else {$suppliers["$DriveId"]}
$assignCell = [Smartsheet.Api.Models.Cell]::new()
$assignCell.COlumnId = $ptAssignCol.Id
$assignCell.Value = if ($orbitalRecord.Assign -ne $null){$orbitalRecord.Assign} else {"ianz#allnewglass.com"}
$finishedCell = [Smartsheet.Api.Models.Cell]::new()
$finishedCell.ColumnId = $ptFinishedCol.Id
$finishedCell.Value = $orbitalRecord.Check
$row = [Smartsheet.Api.Models.Row]::new()
$row.ToBottom = $true
$row.Cells = [Smartsheet.Api.Models.Cell[]]#($poCell,$jobsCell,$descCell,$checkCell,$supCell, $assignCell, $finishedCell)
try
{
$newRow = $client.SheetResources.RowResources.AddRows($ptId, [Smartsheet.Api.Models.Row[]]#($row))
foreach($attachment in $orbitalRecord.Attachments)
{
$file = Get-AttachmentFromSmartsheet -attachmentId $attachment.Id -sheetId $orbitalId
$result = Save-AttachmentToSheetRow -sheetId $ptId -rowId $newRow.Id -file $file.FullName -mimeType $attachment.MimeType
}
}
catch
{
Write-Error $_.Exception.Message
Write-Host ""
}
}
}
}
}
}
}
}
Write-Host "Loading Dlls"
Load-Dll ".\smartsheet-csharp-sdk.dll"
Load-Dll ".\RestSharp.dll"
Load-Dll ".\Newtonsoft.Json.dll"
Load-Dll ".\NLog.dll"
while($true)
{
Write-Host "Fab Log to Driver List to Product Tracker system starting up."
$DriveId = ""
$fabId = ""
$ptId = ""
$suppliers = #{
$fabId = "In Shop FAB";
$DriveId = "DRIVER CHECKLIST";
}
$token = ""
$smartsheet = [Smartsheet.Api.SmartSheetBuilder]::new()
$builder = $smartsheet.SetAccessToken($token)
$client = $builder.Build()
$includes = #([Smartsheet.Api.Models.SheetLevelInclusion]::ATTACHMENTS)
$includes = [System.Collections.Generic.List[Smartsheet.Api.Models.SheetLevelInclusion]]$includes
Write-Host "Loading Sheets"
$Drive = $client.SheetResources.GetSheet($DriveId, $includes, $null, $null, $null, $null, $null, $null);
$fab = $client.SheetResources.GetSheet($fabId, $includes, $null, $null, $null, $null, $null, $null);
$pt = $client.SheetResources.GetSheet($ptId, $includes, $null, $null, $null, $null, $null, $null);
Write-Host "Comparing Objects"
$DriveCOs = Get-DriverComparisonObjects $Drive
$fabCOs = Get-ComparisonObjects $fab
$ptCOs = Get-ComparisonObjects $pt
Write-Host "Identifying Driver Checklist Columns"
#NO SPACE... BODY CHARACTER LIMIT FOR STACK OVERFLOW
Merge-DriverChecklistWithProductTracker -orbitalRecords $DriveCOs -orbitalId $DriveId
Write-Host "Driver Checklist to Product Tracker finished."
Start-Sleep -Seconds 10
}

PowerShell DataTable delete empty rows

I've stumbled upon some (DCOM) issues when using the Excel.Application object. So I've rewritten my function to read Excel files by using the OleDbConnectionand OleDbCommand objects available within AccessDatabaseEngine_x64. So there's no need to install MS Office on the server anymore and it's also more reliable I think.
It works great but the only thing missing is that I can't seem to figure out how to remove empty lines from the output of the function. I know it can be done by using $DataTable[0].Delete(), but I don't know how to determine if a complete row is empty. As it can vary in size depending on the input.
XLSX-File example:
Name | Sir name
Bob Lee | Swagger
|
Jake | Thornton
In the example above I would like to have the output only 2 (or 3 lines depending on the $Header switch), but I don't want to see the blank line in the output.
I found a solution in another language, but I can't translate it to PowerShell.
The code:
Function Import-Excel {
[CmdletBinding()]
Param (
[parameter(Mandatory=$true,Position=0)]
[ValidateScript({Test-Path $_ -PathType Leaf})]
[String]$FileName,
[parameter(Mandatory=$true,Position=1)]
[String]$WorksheetName,
[Switch]$Header
)
Begin {
# We can't read open XLSX-Files
Copy-Item -LiteralPath $FileName -Destination $env:TEMP
}
Process {
$OleDbConnection = New-Object 'System.Data.OleDb.OleDbConnection'
$OleDbCommand = New-Object 'System.Data.OleDb.OleDbCommand'
$ConnString = 'Provider=Microsoft.ACE.OLEDB.12.0;Data Source='
$ConnString += "$env:TEMP\$(Split-Path $FileName -Leaf)"
if ($header) {
$ConnString += ';Extended Properties="Excel 12.0;HDR=YES;IMEX=1";'
}
else {
$ConnString += ';Extended Properties="Excel 12.0;HDR=NO;IMEX=1";'
}
$OleDbConnection.ConnectionString = $ConnString
$OleDbConnection.Open()
$OleDbCommand.Connection = $OleDbConnection
$OleDbCommand.CommandText = "SELECT * FROM [$WorksheetName$]"
$OleDbAdapter = New-Object "System.Data.OleDb.OleDbDataAdapter"
$OleDbAdapter.SelectCommand = $OleDbCommand
$DataTable = New-Object "System.Data.DataTable"
$OleDbAdapter.Fill($DataTable)
$OleDbConnection.Close()
Write-Output $DataTable
}
End {
Remove-Item "$env:TEMP\$(Split-Path $FileName -Leaf)"
}
}
Thank you for your help.
Found the answer in the meantime, for anyone encountering the same issues:
Function Import-Excel {
[CmdletBinding()]
Param (
[parameter(Mandatory=$true,Position=0)]
[ValidateScript({Test-Path -LiteralPath $_ -PathType Leaf})]
[String]$FileName,
[parameter(Mandatory=$true,Position=1)]
[String]$WorksheetName,
[Switch]$Header
)
Begin {
# We can't read open XLSX-Files
Copy-Item -LiteralPath $FileName -Destination $env:TEMP
}
Process {
$OleDbConnection = New-Object 'System.Data.OleDb.OleDbConnection'
$OleDbCommand = New-Object 'System.Data.OleDb.OleDbCommand'
$OleDbAdapter = New-Object 'System.Data.OleDb.OleDbDataAdapter'
$DataTable = New-Object 'System.Data.DataTable'
$ConnString = 'Provider=Microsoft.ACE.OLEDB.12.0;Data Source='
$ConnString += "$env:TEMP\$(Split-Path $FileName -Leaf)"
if ($header) {
$ConnString += ';Extended Properties="Excel 12.0;HDR=YES;IMEX=1";'
}
else {
$ConnString += ';Extended Properties="Excel 12.0;HDR=NO;IMEX=1";'
}
$OleDbConnection.ConnectionString = $ConnString
$OleDbConnection.Open()
$OleDbCommand.Connection = $OleDbConnection
$OleDbCommand.CommandText = "SELECT * FROM [$WorksheetName$]"
$OleDbAdapter.SelectCommand = $OleDbCommand
$OleDbAdapter.Fill($DataTable)
$OleDbConnection.Close()
# Remove empty lines
$Columns = $DataTable.Columns.Count
$Rows = $DataTable.Rows.Count
for ($r = 0; $r -lt $Rows; $r++) {
$Empty = 0
for ($c = 0; $c -lt $Columns; $c++) {
if ($DataTable.Rows[$r].IsNull($c)) {
$Empty++
}
}
if ($Empty -eq $Columns) {
# Mark row for deletion:
$DataTable.Rows[$r].Delete()
}
}
# Delete marked rows:
$DataTable.AcceptChanges()
Write-Output $DataTable
}
End {
Remove-Item "$env:TEMP\$(Split-Path $FileName -Leaf)"
}
}

How to pipe the result of a foreach loop into a csv file with PowerShell

I am having the following syntax problem, and I am still unsure if this is possible or not.
An empty pipe element is not allowed.
The script is
$web = get-spweb https://xx.com/sites/billing
$list = $web.Lists["Bill Cycles"]
foreach($wf in $list.WorkflowAssociations)
{
if ($wf.Name -like "*2013*")
{
foreach($listitem in $list.Items)
{
foreach($Workflow in $listitem.Workflows)
{
if($wf.InternalStatus -ne "Completed")
{
if($Workflow.AssociationId -eq $wf.Id)
{
New-Object psobject -Property #{
"InternalStatus" = $wf.InternalStatus
"WFName" = $wf.Name
"ListItemName" = $listitem.Name
"Url" = $listitem.Url
"Days" = ((Get-Date) - $Workflow.Created).Days
}
}
}
}
}
}
} | Select-Object InternalStatus, WFName, ListItemName, Url, Days | Export-CSV $output -Delimiter ',' -NoTypeInformation
You can make a foreach loop output to the pipeiline by using a sub-expression:
$web = get-spweb https://xx.com/sites/billing
$list = $web.Lists["Bill Cycles"]
$(foreach($wf in $list.WorkflowAssociations)
{
if ($wf.Name -like "*2013*")
{
foreach($listitem in $list.Items)
{
foreach($Workflow in $listitem.Workflows)
{
if($wf.InternalStatus -ne "Completed")
{
if($Workflow.AssociationId -eq $wf.Id)
{
New-Object psobject -Property #{
"InternalStatus" = $wf.InternalStatus
"WFName" = $wf.Name
"ListItemName" = $listitem.Name
"Url" = $listitem.Url
"Days" = ((Get-Date) - $Workflow.Created).Days
}
}
}
}
}
}
}) | Select-Object InternalStatus, WFName, ListItemName, Url, Days | Export-CSV $output -Delimiter ',' -NoTypeInformation
You can also use a scriptblock invocation (wrap the loop in &{} instead of $() )
A foreach loop doesn't output to the pipeline, so it's likely Export-CSV hasn't got any input.
Try wrapping the iteration of WorkflowAssociations in parenthesis.

Resources