Request are not evaluated correctly in async.forEach - node.js

Question

I want to request multiple pages with request in async.forEach. I have several links, and I want to go to each link and get the sublinks from it. Then I want to evaluate each sublink and push results to dataarray. But only the first one sublink is evaluated multiple times, for each links array element. But I want to evaluate each sublink. Here is my code:
var dataarray = [];
var links = ["www.mysite.com/1","www.mysite.com/2","www.mysite.com/3"];
async.whilst(
function() { console.log("Number of links left: " + links.length); return links.length > 0; },
function(innerCallback){
var i1 = getRandomInt(1, links.length); //getRandomInt is a function that gives a random integer in array.
var Theurl = links[i1-1];
request({
url: Theurl,
//More paramaters to request here...
}, function(error, response, body) {
if (response) {
//Evaluate some jquery to get a variable allsublinks used later on.
//So I get several sub-links in each element in links array.
var allsublinks = stuff;
//Now I define a function to be used in async.forEach. I basically need to
//loop over allsublinks array that contains different url links.
function getInfo(name, thiscallback) {
console.log("Online");
console.log("Current url: "+name);
request({
url: name,
//Other parameters to request.
}, function(error, response, body) {
if (response) {
//Here I evaluate some jquery again to get the datafromthislink variable
dataarray.push(datafromthislink);
setTimeout(function() { thiscallback(); });
}
})
}
//Now I use async.forEach to loop over allstorelinks.
async.forEach(allsublinks, getInfo, function(err, results) {
console.log("dataarray: ",dataarray);
setTimeout(function() { links.splice(i1-1, 1); innerCallback(); });
});
}
})
},
function(err){
console.log("All Done");
})
What am I doing wrong?
Best Regards

Answer 1

This could be the cleaner version of what you are trying to achieve, which clear your concept of using callbacks properly.
var dataarray = [];
var links = ["www.mysite.com/1", "www.mysite.com/2", "www.mysite.com/3"];
//Now I define a function to be used in async.forEach. I basically need to
//loop over allsublinks array that contains different url links.
function getInfo(link, infoCallback) {
console.log("Online");
console.log("Current url: " + link);
request({
url: link,
//Other parameters to request.
}, function (error, response, body) {
if (error) console.log(error);
if (response) {
//Here I evaluate some jquery again to get the datafromthislink variable
dataarray.push(body.datafromthislink);
}
infoCallback();
})
}
function getLink(link, linkCallback) {
console.log('checking link: ' + link);
request({
url: link,
//More paramaters to request here...
}, function (error, response, body) {
if (error) console.log(error);
if (response) {
//Evaluate some jquery to get a variable allsublinks used later on.
//So I get several sub-links in each element in links array.
var allsublinks = body.stuff;
//Now I use async.forEach to loop over allstorelinks.
async.forEach(allsublinks, getInfo, linkCallback);
} else {
linkCallback();
}
})
}
async.each(links, getLink, function (err) {
if (error) console.log(error);
console.log("All Done");
console.log(dataarray);
});