Î've read lots of questions recommanding me to avoid using Select. So I've tried to set a target cell but I've met a problem:
I want to use a For Loop to fill a table, but the target cell will change each time with the Loop going on. For example:
Sub try()
Dim target As Range
Set target = Worksheets("Data").Cells(i, 1)
For i = 1 To 10
target.Value = i
Next i
End Sub
So can I use a Range in Loop or not?
If I set the target in the For Loop, I'm afraid it will not be faster than I choose directly the cell Worksheets("Data").Cells(i, 1)in the Loop? Because I'll actually have lots of targets to use, so I wish to find a easier method to set the targets and fill them everytime without setting them one by one.
Sorry if I've post a duplicate question because I didn't find a similar question or an answer on the net. If you've got an idea, please leave a comment. Thank you!
Based on your comment about "reading" each line. This code uses a For Each and examines each cell to see what to do.
Public Sub Test()
Dim rMyRange As Range
Dim rCell As Range
'Define a range on the same sheet.
Set rMyRange = ThisWorkbook.Worksheets("Sheet1").Range("A1:A15,C1:C20,D18,E19:E20")
'Add another range using Union just for the hell of it.
Set rMyRange = Union(rMyRange, ThisWorkbook.Worksheets("Sheet1").Range("F30"))
'Step through each cell in rMyRange and decide what to do based on contents/formatting of cell.
For Each rCell In rMyRange
If rCell = "Colour" Then 'Value is default property.
rCell.Interior.Color = RGB(255, 0, 0)
Else
Select Case rCell.Font.Color
Case 255 'Red
rCell = "Red"
Case 5287936 'Green
rCell = "Green"
Case Else
rCell = "Some Other Colour"
End Select
End If
Next rCell
End Sub
Related
Is it possible to write a vba macro that determines if there are any empty cells in a given range and returns the row number of that cell?
I'm new to vba and all that I managed to write after searching the internet was something that takes a range and colors every emty cell in it red:
Sub EmptyRed()
If TypeName(Selection) <> "Range" Then Exit Sub
For Each cell In Selection
If IsEmpty(cell.Value) Then cell.Interior.Color = RGB(255, 0, 0)
Next cell
End Sub
The macro does basically what I want, but instead of coloring the empty cell red I would like to know the row index of the empty cell.
A little background info: I have a very large file (about 80 000 rows) that contains many merged cells. I want to import it into R with readxl. Readxl splits merged cells, puts the value in the first split cell and NA into all others. But a completely empty cell would also be assigned NA, so I thought the best thing would be to find out which cells are empty with Excel, so that I know which NA indicate a merged cell or an empty cell. Any suggestions on how to solve this problem are very welcome, thanks!
Edit: To clarify: Ideally, I want to unmerge all cells in my document and fill each split cell with the content of the previously merged cell. But I found macros on the web that are supposed to do exactly that, but they didn't work on my file, so I thought I could just determine blank cells and then work on them in R. I usually don't work with Excel so I know very little about it, so sorry if my thought process is far too complicated.
To do exactly what you state in your title:
If IsEmpty(cell.Value) Then Debug.Print cell.Row
But there are also Excel methods to determine merged cells and act on them. So And I'm not sure exactly what you want to do with the information.
EDIT
Adding on what you say you want to do with the results, perhaps this VBA code might help:
Option Explicit
Sub EmptyRed()
Dim myMergedRange As Range, myCell As Range, myMergedCell As Range
Dim rngProcess As Range
With Application
.ScreenUpdating = False
.Calculation = xlCalculationManual
.EnableEvents = False
End With
Set rngProcess = Range("A1:B10")
For Each myCell In rngProcess
If myCell.MergeCells = True Then
Set myMergedRange = myCell.MergeArea
With myMergedRange
.MergeCells = False
.Value = myCell(1, 1)
End With
End If
Next myCell
With Application
.ScreenUpdating = True
.Calculation = xlCalculationAutomatic
.EnableEvents = True
End With
End sub
Note that I explicitly declare all variables, and I hard coded the range to check. There are various ways of declaring the range to be checked; using 'Selection' is usually rarely preferred.
Before anything else: From the opposite end of the spectrum, you can use Range.MergeCells or Range.MergeArea to determine if a Cell is part of a Merged Area. But, I digress...
You can use Cell.Row to get the row number. How you return or display that is up to you - could be a Message Box, a delimited string, or an array, or even a multi-area range.
A Sub cannot return anything once called, so you may want a Function instead, e.g. Public Function EmptyRed() As String
(Also, I would recommend you get in the habit of explicitly declaring all of your variables, and perhaps using Option Explicit too, before you run into a typo-based error. Just add Dim cell As Range at the top of the sub for now)
Sub FF()
Dim r, wksOutput As Worksheet
Dim cell As Range, rng As Range, rngArea As Range
With Selection
.UnMerge
'// Get only blank cells
Set rng = .SpecialCells(xlCellTypeBlanks)
'// Make blank cells red
rng.Interior.Color = vbRed
End With
'// Create output worksheet
Set wksOutput = Sheets.Add()
With wksOutput
For Each rngArea In rng.Areas
For Each cell In rngArea
r = r + 1
'// Write down the row of blank cell
.Cells(r, 1) = cell.Row
Next
Next
'// Remove duplicates
.Range("A:A").RemoveDuplicates Array(1), xlNo
End With
End Sub
There are a couple ways:
Sub EmptyRed()
Dim rgn,targetrgn as range
Dim ads as string ‘ return rgn address
Set targetrgn= ‘ your selection
For Each rgn In Targetrgn
If IsEmpty(rgn.Value) Then
‘1. Use address function, and from there you can stripe out the column and row
Ads=application.worksheetfunction.addres(cell,1)’ the second input control the address format, w/o $
‘2. Range.row & range.column
Ads=“row:” & rgn.row & “, col: “ & rgn.column
End if
Next rgn
End Sub
Ps: I edited the code on my phone and will debug further when I have a computer. And I am just more used to use “range” rather than “cell”.
To clarify: Ideally, I want to unmerge all cells in my document and fill each split cell with the content of the previously merged cell.
Cycle through all cells in the worksheet's UsedRange
If merged, unmerge and fill the unmerged area with the value from the formerly merged area.
If not merged but blank, collect for address output.
Sub fillMerged()
Dim r As Range, br As Range, mr As Range
For Each r In ActiveSheet.UsedRange
If r.Address <> r.MergeArea.Address Then
'merged cells - unmerge and set value to all
Set mr = r.MergeArea
r.UnMerge
mr.Value = mr.Cells(1).Value
ElseIf IsEmpty(r) Then
'unmerged blank cell
If br Is Nothing Then
Set br = r
Else
Set br = Union(br, r)
End If
End If
Next r
Debug.Print "blank cells: " & br.Address(0, 0)
End Sub
Wonder if someone could give me a pointer, or maybe it's already been ask then just a reference, but how can I highlight cells in an excel spreadsheet that contains multiple columns where any portion of a text matches?
Example say cell A2 has the text 'Ionized Sea Salt' and cell D5 has 'Salt'. I would like to highlight those cells because of the matching word 'Salt'.
I don't want to have to add the word I'm searching for in the formula because all the cells and columns will contain hundreds of different strings and I'm looking for matching word(s) per cell.
Thanks
Allthough you should have attempted to at least start coding something, this one is quite fun to work on so hereby my attempt :)
Sub Hightlight()
Dim MyArray() As String
Dim X As Long
Dim C As Range
ActiveSheet.UsedRange.Cells.Interior.Pattern = xlNone 'Clear the hightlighted cells
MyArray() = Split(ActiveCell.Value, " ") 'Get the activecell and split it in array
For X = LBound(MyArray) To UBound(MyArray) 'Loop through your array using .findnext
With ActiveSheet.UsedRange
Set C = .Find(MyArray(X), lookat:=xlPart)
If Not C Is Nothing Then
firstaddress = C.Address
Do
C.Interior.ColorIndex = 37 'color found matched cells
Set C = .FindNext(C)
If C Is Nothing Then
GoTo DoneFinding
End If
Loop While C.Address <> firstaddress
End If
DoneFinding:
End With
Next X
End Sub
The biggest plus of this approach is it wont have to go through thousands of cells, so therefor should be relative fast.
I am sure some true expert can cleanup this code even better :)
Input:
Output:
So.... add a button to your sheet, assign the macro, select a cell, hit the button...
Untested but should work:
Private Sub reset_highlighting()
ActiveSheet.Cells.Interior.Color = xlNone
End Sub
Private Sub highlight_d5()
' Call reset_highlighting < remove comment if you dont want to store prev results
Dim lr as Long
lr = ActiveSheet.Cells(Rows.Count, "A").End(xlUp).Row
Dim search_range as Range: Set search_range = Range(Cells(1,1), Cells(lr, 1))
Dim search_value = Range("D5").Value2
For each cell in search_range
If (InStr(Trim(LCase(cell.Value2)), Trim(LCase(search_value))) != 0) Then
cell.Interior.Color = vbYellow
End If
Next cell
End Sub
Note, you should replace ActiveSheet with Sheets("YourSheetName")
and also might want to adjust your range to fir the criteria
accordingly
PS: Post your efforts of you trying to solve the question in the future. Questions where no attempt was made generally tend to get downvoted here, I only made an exception given you're new here (and I have a good mood today)
I'm trying to resize a range to start at a certain point and resize it down until it hits a cell that contains the text "End of Data"
What would that/those line(s) of code look like? I don't know if you can pass a string find argument to the resize function for range.
Thank you!
These examples assume you're working in column A.
If you don't have any blank cells until the end of your data, you can simply perform the VBA equivalent of pressing Ctrl-Shift-DownArrow:
Range(Range("A1"),Range("A1").End(xlDown)).Select
Otherwise you'll need to first find the cell using a loop or the find function. Looping is a little slower but easier to code:
i = 0
Do
i = i + 1
Loop While Cells(i, 1) <> "End of Data"
Range("A1", Cells(i, 1)).Select
The following guide is good for explaining the various ways to refer to a range of data in VBA:
https://msdn.microsoft.com/en-us/library/office/gg192736(v=office.14).aspx
you could use this function:
Function ResizeRangeDownToACertainString(iniCell As Range, stringToStopAt As String) As Range
Dim endCell As Range
With iniCell.Parent
Set endCell = .Range(iniCell, .Cells(.Rows.count, iniCell.Column)).Find(what:=stringToStopAt, LookIn:=xlValues, lookat:=xlWhole)
If endCell Is Nothing Then
Set ResizeRangeDownToACertainString = iniCell
Else
Set ResizeRangeDownToACertainString = .Range(iniCell, endCell)
End If
End With
End Function
and exploit it in your "main" code as follows
Sub main()
Dim myRng As Range
Set myRng = ResizeRangeDownToACertainString(Range("A2"), "End Of Data")
End Sub
you may want to change the function behavior when it doesn't find the wanted string
I have a spreadsheet which I currently use as a form which I would like to make it impossible to print if specific cells are not filled out. The problem is that I have other macros in the sheet which move around rows dependent on user input. So I can't specifically check certain cells to see if they are empty. I figured I could use conditional formatting to assign a certain color if a field is unlocked and empty and just check each cell in the used range for the presence of that color to prevent printing. However what I built just isn't working. It doesn't provide and error and it doesn't stop printing either. If anyone could help out I would greatly appreciate it. Here is what I have been working with.
Private Sub Workbook_BeforePrint(Cancel As Boolean)
Dim rRng As Range
Dim rCell As Range
Set rRng = ActiveWorkbook.Sheets("Sheet2Name").UsedRange
If ActiveSheet.Name = "Sheet1Name" Then Exit Sub
If ActiveSheet.Name = "Sheet2Name" Then
For Each rCell In rRng.Cells
If rCell.Interior.Color = RGB(0, 255, 0) Then
Cancel = True
MsgBox "All required cells are not filled out, please see supervisor for assistance"
End If
Next rCell
End If
End Sub
The below code I found online and I started adapting it.
Private Sub Worksheet_Change(ByVal Target As Range)
Dim A As Range, B As Range, Inte As Range, r As Range
Set A = Range("A:A")
Set Inte = Intersect(A, Target)
If Inte Is Nothing Then Exit Sub
Application.EnableEvents = False
For Each r In Inte
r.Offset(-1, 1).Value = Now
Next r
Application.EnableEvents = True
End Sub
What I really need to change is instead of this code applying to the entire A column, I need it to start at a specific cell, and apply to every nth cell after that, in a given column.
Can I accomplish that by just modifying the syntax below, or do I need to write a new formula?
If I understand your wishes
Private Sub Worksheet_Change(ByVal Target As Range)
Dim A As Range, B As Range, Inte As Range, r As Range
Set A = Range("B5:C15") ' "B5:C15" - range in which we want to track changes (сan change)
Set Inte = Intersect(A, Target)
If Inte Is Nothing Then Exit Sub
Application.EnableEvents = False
For Each r In Inte
ActiveSheet.Range("E" & r.Row).Value = Now ' "Е" - сolumn for insert the date of change (сan change)
Next r
Application.EnableEvents = True
End Sub
Thank you for responding. That indeed helps clarify some of the ways to define range. Here is a better picture of what I am trying to do:
Solution 1:
I have kind of solved it in a very inefficient way. I have a repeating table on a spread sheet that we just C&P as needed. As long as everyone C&P with the same spacing, my solution works by changing the range to this:
Set A = Range("A5,A10,A15,A20,A25") And then I just add as many increments as I think we will need.
Obviously this is not a desirable way of doing this; I would like to know how to code it so it will do every 5th row in the entire A column, to infinity.
Solution 2:
Probably more advanced than I care to get to in visual basic, but ideally I would like the script to search for a specific word in a cell, and then execute on the next row down. So if it finds the word "Current" in Cell A4, it will execute the script on Cell A5.
If I could make this work, then it would not matter if someone messed up the spacing.
I appreciate your help!