Thread doesn't join with the main thread - multithreading

Question

I'm having a problem with my logger class.
Here's the code:
#include "Logger.h"
Logger::Logger()
{
fileName = new string("log.txt");
out = new ofstream(*fileName, ofstream::out);
stream = new vector<string>;
changed = new bool;
condition = new condition_variable;
myMutex = new mutex;
running = new bool;
if (running)
{
PostQuitMessage(500);
}
if (!out->is_open())
{
exit(3);
}
*running = false;
T = new thread(&Logger::myrun, this);
}
Logger::~Logger()
{
delete fileName;
delete out;
delete stream;
delete changed;
delete condition;
delete myMutex;
delete running;
delete T;
}
void Logger::myrun()
{
*running = true;
while (*running)
{
unique_lock<mutex> lock(*myMutex);
condition->wait(lock, [this] { return *changed; });
for (int c = 0; c < stream->size(); c++)
{
*out << stream->at(c) << endl;
}
stream->clear();
*changed = false;
}
Sleep(100);
}
void Logger::log(string msg)
{
unique_lock<mutex> lock(*myMutex);
stream->push_back(msg);
*changed = true;
condition->notify_one();
}
void Logger::stop()
{
*running = false;
*changed = true;
condition->notify_one();
T->join();
out->close();
}
The thread hangs after the line T->join();
My question is - why does it hang? And how should I resolve it? Please show me in code :)
Thanks in advance!
P.S. All variables are pointers because I use this code is in a dllexport, VS gives me a lot of warnings that it "needs to have dll-interface to be used by clients of class 'Logger'". If anyone has some tips on this one - You are welcome to post :D

Answer 1

I fixed the issue by puttin the destructor code into the method stop and closing the file after joining the thread. I think