The cycle doesn't enter in second if statement in excel - excel

Question

Well, i resolve a little problem abouut one minute ago but now i've another one on my macro :(
Private Sub Workbook_BeforeClose(Cancel As Boolean)
Dim S1 As String, S2 As String
Dim S3 As String, S4 As String
Dim lRow As Long, i As Long
Dim ws As Worksheet
Set ws = ThisWorkbook.Sheets("Sheet1")
S1 = "Football"
S2 = "Basket"
S3 = "Sport1"
S4 = "Sport2"
With ws
lRow = .Range("A" & .Rows.Count).End(xlUp).Row
For i = 1 To lRow
If Len(Trim(.Range("E" & i).Value)) = 0 Then
Select Case .Range("C" & i).Value
Case S1, S2
MsgBox "Insert value in the cell " & _
.Range("E" & i).Address
Cancel = True
Exit For
End Select
End If
If (Len(Trim(.Range("F" & i).Value)) = 0) Or _
(Len(Trim(.Range("G" & i).Value)) = 0) Or _
(Len(Trim(.Range("H" & i).Value)) = 0) Then
Select Case .Range("C" & i).Value
Case S3, S4
MsgBox "Insert value in the cell " & _
.Range("F" & i).Address, _
.Range("G" & i).Address, _
.Range("H" & i).Address
Cancel = True
Exit For
End Select
End If
Next i
End With
End Sub
The first if works but the second
If (Len(Trim(.Range("F" & i).Value)) = 0) Or _
(Len(Trim(.Range("G" & i).Value)) = 0) Or _
(Len(Trim(.Range("H" & i).Value)) = 0) Then
Select Case .Range("C" & i).Value
Case S3, S4
MsgBox "Insert value in the cell " & _
.Range("F" & i).Address, _
.Range("G" & i).Address, _
.Range("H" & i).Address
Cancel = True
Exit For
End Select
End If
Nope. Is there something wrong?
As you can see is the same condition but in different columns

Answer 1

If the first IF works then then second will not as we are exiting the FOR Loop.
Is this what you are trying (UNTESTED)?
Private Sub Workbook_BeforeClose(Cancel As Boolean)
Dim S1 As String, S2 As String
Dim S3 As String, S4 As String, sMsg As String
Dim lRow As Long, i As Long
Dim ws As Worksheet
Set ws = ThisWorkbook.Sheets("Sheet1")
S1 = "Football": S2 = "Basket": S3 = "Sport1": S4 = "Sport2"
With ws
lRow = .Range("A" & .Rows.Count).End(xlUp).Row
For i = 1 To lRow
If Len(Trim(.Range("E" & i).Value)) = 0 Then
Select Case .Range("C" & i).Value
Case S1, S2
sMsg = .Range("E" & i).Address
End Select
End If
If (Len(Trim(.Range("F" & i).Value)) = 0) Or _
(Len(Trim(.Range("G" & i).Value)) = 0) Or _
(Len(Trim(.Range("H" & i).Value)) = 0) Then
Select Case .Range("C" & i).Value
Case S3, S4
If sMsg = "" Then
sMsg = .Range("F" & i).Address & " OR " & _
.Range("G" & i).Address & " OR " & _
.Range("H" & i).Address
Else
sMsg = sMsg & " OR " & _
.Range("F" & i).Address & " OR " & _
.Range("G" & i).Address & " OR " & _
.Range("H" & i).Address
End If
End Select
End If
If sMsg <> "" Then
MsgBox "One or all these cells are empty. " & _
"Please insert value in the cell(s) " & _
sMsg
Cancel = True
Exit For
End If
Next i
End With
End Sub
FOLLOWUP (from comments)
UNTESTED
This stores the relevant cells in a range and then simply selects it after activating the relevant sheet. However I do not recommend this method. Alternatively you could color the cells... either via code or via conditional formatting...
Private Sub Workbook_BeforeClose(Cancel As Boolean)
Dim S1 As String, S2 As String
Dim S3 As String, S4 As String, sMsg As String
Dim lRow As Long, i As Long
Dim ws As Worksheet
Dim rng As Range
Set ws = ThisWorkbook.Sheets("Sheet1")
S1 = "Football": S2 = "Basket": S3 = "Sport1": S4 = "Sport2"
With ws
lRow = .Range("A" & .Rows.Count).End(xlUp).Row
For i = 1 To lRow
If Len(Trim(.Range("E" & i).Value)) = 0 Then
Select Case .Range("C" & i).Value
Case S1, S2
sMsg = .Range("E" & i).Address
Set rng = .Range("E" & i)
End Select
End If
If (Len(Trim(.Range("F" & i).Value)) = 0) Or _
(Len(Trim(.Range("G" & i).Value)) = 0) Or _
(Len(Trim(.Range("H" & i).Value)) = 0) Then
Select Case .Range("C" & i).Value
Case S3, S4
If sMsg = "" Then
sMsg = .Range("F" & i).Address & " OR " & _
.Range("G" & i).Address & " OR " & _
.Range("H" & i).Address
Else
sMsg = sMsg & " OR " & _
.Range("F" & i).Address & " OR " & _
.Range("G" & i).Address & " OR " & _
.Range("H" & i).Address
End If
If rng Is Nothing Then
Set rng = .Range("F" & i & ":H" & i)
Else
Set rng = Union(rng, .Range("F" & i & ":H" & i))
End If
End Select
End If
If sMsg <> "" Then
MsgBox "One or all these cells are empty. " & _
"Please insert value in the cell(s) " & _
sMsg
If Not rng Is Nothing Then
.Activate
rng.Select
End If
Cancel = True
Exit For
End If
Next i
End With
End Sub