Why does my overloading constructor produces a crash? - visual-c++

Question

Basically, when overloading operator (operator--) constructor is called
my program crashes, changing classes arrays from dynamic, to static ones,
solves the problem, why is that?
If classes arrays are change from dynamic to static, overloading works
great, but this isn't a solution I am looking for.
The working version with static array:
#include <iostream>
#include<string>
using namespace std;
const int TABLE = 10;
class Player()
{
private:
int health;
string A[TABLE][TABLE];
public:
Player()
{
health = 17;
for (int i = 0; i < TABLE; i++)
{
for (int j = 0; j < TABLE; j++)
A[i][j] = "-";
}
}
Player(int new_health)
{
health = new_health;
}
Player operator--()
{
health--;
return Player(health);
}
~Player(){}
};
int main()
{
Player p1; // Creates object p1 and calls Player(), initializing
health variable, and string A array.
--p1; // Decrements p1 health value
return 0;
}
Dynamic array version:
#include <iostream>
#include<string>
using namespace std;
const int TABLE = 10;
class Player()
{
private:
int health;
string **A;
public:
Player()
{
health = 17;
A = new string*[TABLE];
for (int i = 0; i < TABLE; i++)
{
A[i] = new string[TABLE];
}
for (int i = 0; i < TABLE; i++)
{
for (int j = 0; j < TABLE; j++)
A[i][j] = "-";
}
}
Player(int new_health)
{
health = new_health;
}
Player operator--()
{
health--;
return Player(health);
}
~Player()
{
for (int i = 0; i < TABLE; i++)
delete[] A[i];
delete[] A;
}
};
int main()
{
Player p1; // Creates object p1, calls Player(), set health value,
initializes dynamic array
--p1; // Produces a crash with exit status -1
return 0;
}
No error messages, the crash doesn't happen at the health = new_health
part, it crashes as soon as Player(int new_health) constructor has done
its job. How can dynamic arrays affect overloading constructor and cause a crash?

Answer 1

The error is occurring because the new player instance that you create in your -- overload is getting destructed; however, your constructor overload never initialized your dynamic array. So when the destructor is called you are trying to delete unallocated memory.