I've just began learning Python 3 about 2 weeks ago. I decided to make a basic text game However, I've run into a bug in the code that I can't seem to fix, and that I can't find anywhere else. When I run my game (code incoming), I get this error:
Welcome to the room. This is the room in which this game takes place
Press enter to continue.
What would you like to do? Type HELP for your options
HELP
Traceback (most recent call last):
File "C:/Users/Michael/Desktop/mess.py", line 35, in <module>
inputFunc()
File "C:/Users/Michael/Desktop/mess.py", line 7, in inputFunc
inputExam()
File "C:/Users/Michael/Desktop/mess.py", line 9, in inputExam
if (inSet == "LOOK"):
NameError: global name 'inSet' is not defined
Here is the code for my game:
# functions:
def youLose():
print("You lost.")
def inputFunc():
print("What would you like to do? Type HELP for your options")
inSet = input()
inputExam()
def inputExam():
if (inSet == "LOOK"):
print("You are in a room. There is a door in front of you. You have a key in your hand. There is a slip of paper on the ground.")
inputFunc()
elif (inSet == "HELP"):
print("Use LOOK to examine your surroundings. Use OPEN to open things. Use EXAMINE to examine things. Use QUIT to quit the game. Remember to use ALL CAPS so the processor can understand you")
inputFunc()
elif (inSet == "EXAMINE PAPER"):
print("The paper reads: 'There is only one winning move'")
inputFunc()
elif (inSet == "OPEN DOOR"):
print("You open the door using your key. There is a bright light on the other side, blinding you. You feel a familiar feeling as you realize that you have died.")
input("Press enter to continue.")
youLose()
elif (inSet == "EXAMINE DOOR"):
print("A simple oaken door.")
inputFunc()
elif (inSet == "QUIT"):
print("You hear a clicking of gears. You realize that the only winning move is not to play. You Win!")
elif (inSet == "EXAMINE KEY"):
print("A small, brass key that looks to fit the lock on the door.")
inputFunc()
else:
print("Syntax Error")
# base:
print("Welcome to the room. This is the room in which this game takes place")
input("Press enter to continue.")
inputFunc()
Your problem is variable scope:
def inputFunc():
print("What would you like to do? Type HELP for your options")
inSet = input()
inputExam()
def inputExam():
if (inSet == "LOOK"):
...
inSet is defined in inputFunc. It doesn't exist outside of inputFunc, so you cannot use it in inputExam.
You can either make it a global:
inSet = ''
def inputFunc():
global inSet
print("What would you like to do? Type HELP for your options")
inSet = input()
inputExam()
def inputExam():
global inSet
if (inSet == "LOOK"):
...
Or pass it as an argument to inputExam:
def inputFunc():
print("What would you like to do? Type HELP for your options")
inSet = input()
inputExam(inSet)
def inputExam(inSet):
if (inSet == "LOOK"):
...
I would go with the latter.
Related
I am working on a very simple 'game' where the player gets 5 guesses to guess a random number.
It's not done yet but I have run into a couple of problems.
This is the code that generates a random number and allows the player to guess
Relevant code:
def GuessLoopFunc(guess):
import random
import sys
import time
sum_guesses = 0
rand_num = random.randrange(1, 21)
print(rand_num)
#This is just for test purposes to know the correct number and see what happens when I guess the correct number
while True:
if guess == rand_num:
print("You got it right!")
else:
sum_guesses += 1
if sum_guesses == 4:
guess = input("That's incorrect...final guess: ")
continue
elif sum_guesses == 5:
print("Oh no! You lost!")
while True:
replay = input("Do you want to play again: ")
if replay == "yes" or replay == "Yes":
pass #Temporary while I figure out how to loop back to very start (new random number)
elif replay == "no" or replay == "No":
print("Goodbye")
break
else:
print("I do not understand what you mean...")
continue
else:
guess = input("You got it wrong, guess again: ")
continue
As you can see by the comments I made, I want the game the return to the very start of the program if the player indicates they want to play again (so they get a new random number.
Also, for some reason, the game doesn't register when the correct answer was given and keeps on telling the player that his answer was incorrect...this is the code of the game where the above module is called:
import sys
import random
import time
from GuessLoop import GuessLoopFunc
print("Hello! Welcome to the guess the number game!")
name_player = input("Please enter your name: ")
print("Hello " + str(name_player) + "!")
play = input("Are you ready to play? ")
if play == "Yes" or play == "yes":
print("Great! Let's get started...")
elif play == "No" or play == "no":
print("Too bad...")
sys.exit()
else:
print("I do not understand your response...")
quit1 = input("Do you want to quit? ")
if quit1 == "yes" or quit1 == "Yes":
sys.exit()
elif quit1 == "no" or quit1 == "No":
print("Great! Let's get started!")
else:
print("I do not understand your response...quitting.")
sys.exit()
print("I am going to think of think of a number between 1 and 20...")
print("You will get 5 guesses to guess the number...")
time.sleep(1)
print("Okay, I have a number in mind")
guess = input("What is your guess? ")
GuessLoopFunc(guess)
time.sleep(1)
sys.exit()
Finally, when I try to run the program in Sublime Text it doesn't run further than the "Please enter your name: " part. If I fill in my name and press enter, nothing happens...but no error message displays either. So I have resorted to testing the program in the Python IDLE every time, but it's a bit tedious...anyone know what's up.
Your main problem is that you compare your userinput (a string) with a random number (integer) - they will never be the same as string != int.
Solution:
You need to convert the user input to a number via the int(text) function.
def getInt(text):
while True:
try:
n = input(text)
return int(n)
except ValueError: # if the input is not a number try again
print(f"{n} is not a number! Input a number")
....
guess = getInt("What is your guess?") # now that is an int
....
You have lots of duplicate "yes/no" codeparts that you can streamline:
def YesNo(text):
'''Ask 'test', returns True if 'yes' was answerd else False'''
while True:
answer = input(text).strip().lower()
if answer not in {"yes","no"}:
print("Please answer 'yes' or 'no'")
continue # loop until yes or no was answered
return answer == "yes"
This reduces
quit1 = input("Do you want to quit? ")
if quit1 == "yes" or quit1 == "Yes":
sys.exit()
elif quit1 == "no" or quit1 == "No":
print("Great! Let's get started!")
to
if YesNo("Do you want to quit? "):
sys.exit()
else:
pass # do somthing
and use that in all yes/no questions.
To play again I would move the "Do you want to play again" question out of the game loop:
# do your name questioning and greeting here
# and then enter an endless loop that you break from if not playing again
while True:
GuessLoopFunc() # move the guess input inside the GuessLoopFunk as it has
# to be done 5 times anyhow. If you spend 5 guesses or
# guessed correctly, print some message and return to here
if YesNo("Play again? "):
continue
else:
break # or sys.exit()
To fix the sublime problem: Issue with Sublime Text 3's build system - can't get input from running program
After I finish my hangman game, when I clear the console, it clears everything. However, I want it to not clear the menu. How do I fix this?
Here is my code:
import random, os
import time
print("^^^^^^^^^^THIS IS HANGMAN^^^^^^^^^^")
print("1. Play Game ")
print("2. Quit Game ")
choice = input("Please enter option 1 or 2")
if choice == "1":
words = ["handkerchief", "accommodate", "indict", "impetuous"]
word = random.choice(words)
guess = ['_'] * len(word)
guesses = 7
while '_' in guess and guesses > 0:
print(' '.join(guess))
character = input('Enter character: ')
if len(character) > 1:
print('Only enter one character.')
continue
if character not in word:
guesses -= 1
for i, c in enumerate(word):
if c == character:
guess[i] = character
if guesses == 0:
print('You LOST!')
break
else:
print('You have only', guesses, 'chances left to win.')
else:
print(''.join(guess))
print('You WON, well done')
time.sleep(2)
import os
os.system('clear')
I don't know how to make the code so that it only clears down to the menu
simply wrap your menu in a function
def menu():
print("^^^^^^^^^^THIS IS HANGMAN^^^^^^^^^^")
print("1. Play Game ")
print("2. Quit Game ")
and reprint it after you clear the console
import os
os.system('clear')
menu()
if you want your menu to still work after the clear, just include all the code you use to make your menu work into the menu() function. Good luck on your project
I know this is probably a very simple fix, but I cannot seem to make the code work. Here is the problematic excerpt:
def main_menu():
print("Welcome! Please Choose An Option to Proceed")
print("1. New: Input Letters Into A New Excel Document")
print("2. Add: Add New Letters To An Existing Excel Document")
while True:
choice = input("Enter Option Number: ")
if choice.lower() in ['1','2']:
return choice.lower()
else:
print("Invalid Number Choice")
continue
def menu_choice(main_menu):
while True:
choice = main_menu()
if choice == "1":
newsession()
elif choice == "2":
addsession()
else:
break
def newsession():
while True:
try:
txtfilenameinput = input("1. Enter 'Txt' Input File Name: ")
inputfilename = txtfilenameinput.replace(".txt" , "")
inputfile = codecs.open(inputfilename + ".txt" , "r" , encoding = "utf-8" , errors = "ignore")
print("File Found" + "\n")
break
except FileNotFoundError:
print("File Not Found: Make Sure The File Is Spelled Correctly And That Both The Program and File Is On The Desktop Screen" + "\n")
if __name__ == '__main__':
main_menu()
closeprogram = input("Press Enter Key To Close Program")
My objective is, for example, when an input of "1" is inserted in main_menu(), the script would then start to run the newsession() function. Yet for some reason, the program does nothing but jumps to the end of the script (a "press key to close program" command) without engaging the newsession() function. This holds true for an input of "2" for the addsession() function as well. What am I doing wrong? I have tried everything but nothing allows my input choice of 1 or 2 to continue the progress in my script. Thank you for your help!
Try the code below. It allows to exit from the program and it returns again and again for more user input:
def main_menu():
print("Welcome! Please Choose An Option to Proceed")
print("1. New: Input Letters Into A New Excel Document")
print("2. Add: Add New Letters To An Existing Excel Document")
print(" QUIT with 'q'")
while True:
choice = input("Enter Option Number: ")
if choice.lower() in ['1','2','q']:
return choice.lower()
else:
print("Invalid Number Choice")
continue
def menu_choice(main_menu):
while True:
choice = main_menu()
if choice == "1":
newsession()
elif choice == "2":
addsession()
else:
break
The problem with your code was that you were "trapped" in a while True: loop with no escape. So after ONE single user choice newsession() or addsession() were started again and again with no further progress in the script and no way to change anything about it except to kill the program. Remember: each while True loop should have at least one line containing brake or return, else it is a never ending story ...
The problem with not reaching the newsession() is HERE:
if __name__ == '__main__':
main_menu()
where it should be:
if __name__ == '__main__':
menu_choice()
When i went from python 2.7 to python 3.5 I started having problem with ELIF statement.
I am using PyCharm so when i enter elif statement it shows an error and this1
this is what jumps up as error solution
and when I press it this happens but code still doesn't works...
doesn't let me post this pic, it will be in comments
Anyways, i cant post code for some reason so it will be in comments if you need him and please help me if you can because this is not first time happening, I can't find help anywhere and well it's really annoying...
Your first error is not having an initial if statement as well as having game = '1': instead of game == '1':. If you look at my code I have fixed these errors and fixed the indentation as it was causing some bugs
import os
print("\nWelcome, enter Your name please")
name = input("--> ")
def username(name): #NAME
while len(name) < 2:
print("There was an error")
name = input("\nPlease enter Your name again -->")
else:
print("Hello,", name)
username(name)
def menu(): #MENU
print("\nWelcome to the menu")
print("From here You can chose the game")
print("For now, we have only 3 game but there will be plenty more!")
print("Chose game by it's number ")
print("1 - Coin flip| 2 - Horse racing| 3 - Loto|")
menu()
game = int(input("--> "))
def choice(game): #CHOOSING GAME
while game > 3 or game < 1:
print("\nSomething went wrong, enter game you want again (only numbers 1, 2, 3!")
game = int(input("--> "))
if game == '1': #if statement first and two "=" signs
print("You chose Coin flip game")
os.system('python coinflip.py')
elif game == '2': #use tab to indent properly
print("You chose Horse racing game")
os.system('python horseracing.py')
elif game == '3': #keep indentations the same throughout
print("You chose Loto game")
os.system("python loto.py")
choice(game)
You need to firstly type "if" and the "elif". So it should be something like that:
def choice(game): #CHOOSING GAME
while game > 3 or game < 1:
print("\nSomething went wrong, enter game you want again (only numbers 1, 2, 3!")
game = int(input("--> "))
if game == '1': #bug here
print("You chose Coin flip game")
os.system('python coinflip.py')
elif game == '2': #and here
print("You chose Horse racing game")
os.system('python horseracing.py')
elif game == '3': #and here
print("You chose Loto game")
os.system("python loto.py")
Can anyone see why I get "UnBoundLocal Error" for my score varible?
import random
Score=0
def Main_Menu(Score):
print("=============================")
print("WELCOME TO MY QUIZ")
print("=============================")
while True:
Username=input("What is your name?")
if Username.isalpha():
if len(Username)>11:
print("You are only a maximum of 11 characters")
else:
Username=Username.title()
break
else:
print("Letters only")
while True:
while True:
Option=input("What do you want to do?\n1 For Quiz\n2 To Quit.")
if Option.isdigit():
Option=int(Option)
break
else:
print("Numbers Only.")
if Option==1:
for x in range(10):
Quiz(Username)
print("You have scored",Score,"point out of 10!!\n")
elif Option==2:
input("Press Enter to quit the program")
break
else:
print("You only have 2 options")
Quiz(Username)
def Quiz(Username):
Tries=3
Number_One=random.randint (0,10)
Number_Two=random.randint (0,10)
Arithmetic_Operator=random.choice(["+","-","*",])
if Arithmetic_Operator=="+":
print(Username,"\nWhat is",Number_Two,"+",Number_One,"?")
Answer=Number_Two+Number_One
elif Arithmetic_Operator=="-":
print(Username,"\nWhat is",Number_Two,"-",Number_One,"?")
Answer=Number_Two-Number_One
elif Arithmetic_Operator=="*":
print(Username,"\nWhat is",Number_Two,"*",Number_One,"?")
Answer=Number_Two*Number_One
while Tries!=0:
while True:
Guess=input("Answer: ")
if Guess.isdigit():
Guess=int(Guess)
break
else:
print("Numbers Only.")
if Guess==Answer:
print("Well Done.You got it right.\nYou have a point")
Score=Score+1
break
elif Guess!=Answer:
Tries=Tries-1
print("You have",Tries,"tries left")
if Tries==0:
print("The answer is",Answer)
Main_Menu(Score)
You are getting the UnboundLocalError: local variable 'Score' referenced before assignment error because the Quiz method doesn't have a local variable Score but is trying to read from it. You probably meant to use the the global variable Score, but it's not available in the method scope without using the global statement. You can fix this by adding global Score in the beginning of the Quiz method.
However, using globals in python code is another discussion, I would strongly recommend avoiding them, unless there's really a proper reason to use them. Please see this SO for more details and discussion.